Bug 270611 - net-im/signal-desktop: Build error
Summary: net-im/signal-desktop: Build error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-02 21:39 UTC by Thomas Zander
Modified: 2023-04-04 10:27 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer freebsd_triage 2023-04-02 21:39:12 UTC 
I'm getting this when building signal desktop 6.12 in poudriere:

=======================<phase: build          >============================
===>  Building for signal-desktop-6.12.0
echo 'yarn-offline-mirror "../yarn-offline-cache"' > /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-6.12.0/.yarnrc
/bin/chmod -R a+w /wrkdirs/usr/ports/net-im/signal-desktop/work/electron22
/bin/mkdir -p /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-libsignal-client-0.22.0-d57441612df46f90df68fc5d9ad45b857b9d2c44-integrity/node_modules/@signalapp/libsignal-client/prebuilds/freebsd-x64  /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.25.2-6e6e32fe3e507f1ead7cd287d53eb35d1f9b5ef9-integrity/node_modules/@signalapp/ringrtc/build/freebsd
cp -f /usr/local/lib/libsignal_node.so  /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-libsignal-client-0.22.0-d57441612df46f90df68fc5d9ad45b857b9d2c44-integrity/node_modules/@signalapp/libsignal-client/prebuilds/freebsd-x64/node.napi.node
cp -f /usr/local/lib/libringrtc.so  /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.25.2-6e6e32fe3e507f1ead7cd287d53eb35d1f9b5ef9-integrity/node_modules/@signalapp/ringrtc/build/freebsd/libringrtc-x64.node
/bin/mkdir -p /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-better-sqlite3-8.4.3-7ffa8d03d2a12543247936bfb7b9f74cdbc6fe9b-integrity/node_modules/@signalapp/better-sqlite3/deps
cp -f /portdistfiles/sqlcipher-4.5.3-fts--3.0.7--0.2.1-b633825cf7e0fdd39a6cdf128f2bd76552a88d325f2b9cd07bb87a457cefb986.tar.gz  /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-better-sqlite3-8.4.3-7ffa8d03d2a12543247936bfb7b9f74cdbc6fe9b-integrity/node_modules/@signalapp/better-sqlite3/deps/sqlcipher.tar.gz
cp -f /usr/ports/net-im/signal-desktop/files/fetch-prebuild.js  /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.25.2-6e6e32fe3e507f1ead7cd287d53eb35d1f9b5ef9-integrity/node_modules/@signalapp/ringrtc/scripts/fetch-prebuild.js
cp: /wrkdirs/usr/ports/net-im/signal-desktop/work/.cache/yarn/v6/npm-@signalapp-ringrtc-2.25.2-6e6e32fe3e507f1ead7cd287d53eb35d1f9b5ef9-integrity/node_modules/@signalapp/ringrtc/scripts/fetch-prebuild.js: No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/signal-desktop
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2023-04-03 07:24:52 UTC 
I can't reproduce here.
Do you have a full build log? work/.cache dir is populated in the post-extract phase (with yarn install).
I bet it's the latest node update, I suppose you have node-16.20.0?
Comment 2 ml 2023-04-03 16:40:11 UTC 
(In reply to Mikael Urankar from comment #1)

Just a "me too".

Full build log:
https://www.netfence.it/download/131amd64-default.log

I'm building in Poudriere in a jail on 13.1/amd64 and yes, I have node-16.20.0, as that's what comes with 2023Q2 port tree.

TIA.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2023-04-03 18:37:06 UTC 
Yeah, it fails because of the node update:
error signal-desktop@6.12.0: The engine "node" is incompatible with this module. Expected version "16.19.1". Got "16.20.0"

I'll try to update the port tomorrow
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2023-04-03 18:43:52 UTC 
You can try to bump NODE_VERSION and "make makesum", maybe it'll fix the problem (same goes for net-im/libsignal-node)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-04-04 06:50:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0ffba94107e9889f6cd81d287a8cc485b40f64b7

commit 0ffba94107e9889f6cd81d287a8cc485b40f64b7
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2023-04-04 06:35:00 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-04-04 06:49:02 +0000

    net-im/signal-desktop: Bump NODE_VERSION and ELECTRON_GYP_VERSION

    Bump NODE_VERSION and ELECTRON_GYP_VERSION after node and electron update.

    PR:             270611
    Reported by:    riggs

 net-im/signal-desktop/Makefile |  4 ++--
 net-im/signal-desktop/distinfo | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)
Comment 6 ml 2023-04-04 09:39:08 UTC 
(In reply to commit-hook from comment #5)

Thanks.
I manually merged this in my own quarterly branch and it works.
I had no trouble with libsignal-node, though.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-04-04 10:27:11 UTC 
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=56dd506ee27ed20296685a3ed72ad12f1d931e87

commit 56dd506ee27ed20296685a3ed72ad12f1d931e87
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2023-04-04 06:35:00 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-04-04 10:23:06 +0000

    net-im/signal-desktop: Bump NODE_VERSION and ELECTRON_GYP_VERSION

    Bump NODE_VERSION and ELECTRON_GYP_VERSION after node and electron update.

    PR:             270611
    Reported by:    riggs

    (cherry picked from commit 0ffba94107e9889f6cd81d287a8cc485b40f64b7)

 net-im/signal-desktop/Makefile |  4 ++--
 net-im/signal-desktop/distinfo | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)