Bug 270627 - net-mgmt/fence-agents: Follow Porters Handbook more closely and use helpers
Summary: net-mgmt/fence-agents: Follow Porters Handbook more closely and use helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-03 15:34 UTC by Daniel Engberg
Modified: 2023-04-05 06:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)

Attachments
Patch for fence-agents (846 bytes, patch)
2023-04-03 15:34 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-03 15:34:47 UTC 
Created attachment 241286 [details]
Patch for fence-agents

Use DISTVERSION instead of PORTVERSION as instructed in Porters Handbook and use framework helper to define libxslt build dependency
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2023-04-03 16:09:34 UTC 
go ahead and push,

Thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-04-05 06:28:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=92fb8ba04418ad80432302eb9caa241efe891ccc

commit 92fb8ba04418ad80432302eb9caa241efe891ccc
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-05 06:26:10 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-05 06:26:14 +0000

    net-mgmt/fence-agents: Follow Porters Handbook more closely and use helpers

    Use DISTVERSION instead of PORTVERSION as instructed in Porters Handbook
    and use framework helper to define libxslt build dependency

    PR:             270627
    Reviewed by:    bapt (maintainer)

 net-mgmt/fence-agents/Makefile | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-04-05 06:28:50 UTC 
Thanks