Bug 270664 - devel/qt6-base: Prefer the shared version of libzstd over the static one
Summary: devel/qt6-base: Prefer the shared version of libzstd over the static one
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks: 270690
  Show dependency tree / graph
 
Reported: 2023-04-05 21:41 UTC by Daniel Engberg
Modified: 2023-04-15 18:06 UTC (History)
5 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Patch for qt6-base (1.07 KB, patch)
2023-04-05 21:41 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-05 21:41:33 UTC 
Created attachment 241317 [details]
Patch for qt6-base

Backport commit 3f45905953d57e0174059d7d9d6bc75c3c1c406c as without this patch QT pulls in static library of (lib)zstd when CMake files are available which causes build failure and is inconsistent with behaviour using pkgconfig

Reference:
https://github.com/qt/qtbase/commit/3f45905953d57e0174059d7d9d6bc75c3c1c406c

Poudriere testport OK 12.4-RELEASE (amd64)

Additional info:
Fixes build after https://cgit.freebsd.org/ports/commit/?id=72ad532057c9f9fb6fa370c80f663c005e9dd021
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-04-06 08:28:44 UTC 
Thanks a lot for the fast patch!

I'm running it with success here. Hope this can be  approved and committed soon!
Comment 2 Dima Panov freebsd_committer freebsd_triage 2023-04-06 08:54:01 UTC 
BTW, with zstd fully converted to cmake this issue didn't rise up at all. 

This is an autocrap tools failure not a qt of zstd itself
Comment 3 Robert Cina 2023-04-06 14:56:44 UTC 
I can confirm the patch works on 13.2 stable amd64 using poudriere here as well. Thanks for the quick patch.
Comment 4 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-04-09 23:43:49 UTC 
It should be fixed in ports 454e3c91ae9105a9af1939c9632424083ed3bbdb.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-04-10 08:10:24 UTC 
According to upstream the commited fix (adding -fPIC) is not recommended, https://github.com/facebook/zstd/issues/2233#issuecomment-655600389
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-04-14 19:46:17 UTC 
Friendly ping kde@ Team
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2023-04-15 17:37:34 UTC 
Ship it.


mfg Tobias
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-04-15 18:04:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=93865c964d29fb5d49b7b2651735f955ead4d019

commit 93865c964d29fb5d49b7b2651735f955ead4d019
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-15 17:57:41 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-15 18:03:57 +0000

    devel/qt6-base: Prefer shared library for libzstd

    Backport upstream commit 3f45905953d57e0174059d7d9d6bc75c3c1c406c as
    without this patch QT by default pulls in (lib)zstd's static library
    when CMake files are available which causes build failure unless (lib)zstd
    is compiled with -fPIC (non standard option) and is inconsistent with
    behaviour using pkgconfig

    PR:             270664
    Approved by:    kde (tcberner)

 devel/qt6-base/Makefile | 3 +++
 devel/qt6-base/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2023-04-15 18:06:24 UTC 
Thanks