Bug 270665 - archivers/py-borgbackup: Update to 1.2.4
Summary: archivers/py-borgbackup: Update to 1.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-06 07:03 UTC by Juraj Lutter
Modified: 2023-04-09 13:37 UTC (History)
3 users (show)

See Also:
mandree: maintainer-feedback+
mandree: maintainer-feedback+


Attachments
Update to 1.2.4 (2.14 KB, patch)
2023-04-06 07:03 UTC, Juraj Lutter
mandree: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Juraj Lutter freebsd_committer freebsd_triage 2023-04-06 07:03:37 UTC
Created attachment 241319 [details]
Update to 1.2.4

Please update the py-borgbackup to 1.2.4, as it supportes msgpack 1.0.5 that we have in ports now.

See the patch attached or online at http://freebsd-current.builder.wilbury.net/patches/FreeBSD-ports/archivers/py-borgbackup/0001-archivers-py-borgbackup-Update-to-1.2.4.patch
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2023-04-07 08:57:06 UTC
@sunpoet, please note that py-borgbackup pins the required [py-]msgpack version,  so we need to coordinate your py-msgpack update with py-borgbackup updates.
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2023-04-07 09:07:41 UTC
I am testing as we 'speak'.
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2023-04-07 09:08:10 UTC
Comment on attachment 241319 [details]
Update to 1.2.4

Thanks for your attention to detail, much appreciated.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-07 09:39:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1cc1228785eef2fb840a399058d35e5af1e16395

commit 1cc1228785eef2fb840a399058d35e5af1e16395
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2023-04-07 09:31:47 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-04-07 09:38:11 +0000

    archivers/py-borgbackup: update to 1.2.4, unbreaking with msgpack 1.0.5

    Borgbackup pins the exact, full, patch-level based version range
    and the prior borgbackup 1.2.3 wanted to have at most msgpack 1.0.4.

    Update to 1.2.4 which allows msgpack 1.0.5, and pin the exact msgpack
    version in our depends to "fail early".

    And other changes including bug fixes:
    https://github.com/borgbackup/borg/blob/1.2.4/docs/changes.rst#version-124-2023-03-24

    based on a
    PR:             270665
    Submitted by:   otis@

    As in-depth soft robustness measure, add relevant warning comments to
    devel/py-msgpack/Makefile, and while there, clean up the python:3.6+
    to just a bare python because 3.6 and older are long gone from ports.

 archivers/py-borgbackup/Makefile | 7 ++++---
 archivers/py-borgbackup/distinfo | 6 +++---
 devel/py-msgpack/Makefile        | 6 ++++--
 3 files changed, 11 insertions(+), 8 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-04-07 10:23:01 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e41c4c7e6ba26e855a7fb8bc750270801fd50b0

commit 9e41c4c7e6ba26e855a7fb8bc750270801fd50b0
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2023-04-07 10:20:24 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-04-07 10:20:24 +0000

    archivers/py-borgbackup: bugfix update to 1.2.4

    Also tighten up py-msgpack requirement, and factor it out.

    PR:             270665
    Reported by:    otis@

    Note this is not a cherry-pick.

 archivers/py-borgbackup/Makefile | 9 +++++----
 archivers/py-borgbackup/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 7 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-04-07 10:34:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c9a9321d00c80f557f1a2da32ca7439d7fad0a70

commit c9a9321d00c80f557f1a2da32ca7439d7fad0a70
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2023-04-07 10:30:16 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-04-07 10:32:12 +0000

    archivers/py-borgbackup: also tighten up RUN_DEPENDS for msgpack

    and refactor. After the version in 2023Q2, and related to:
    PR:             270665

 archivers/py-borgbackup/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-04-09 13:37:58 UTC
I always check dependent ports when updating a port. py-borgbackup has to declare correct version range in *_DEPENDS. Since you've done this change in ports 1cc1228785eef2fb840a399058d35e5af1e16395 and ports 9e41c4c7e6ba26e855a7fb8bc750270801fd50b0, it'll be fine in future updates.