Bug 270714 - devel/android-tools: can't make on 14.0-Current
Summary: devel/android-tools: can't make on 14.0-Current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-09 02:39 UTC by Masachika ISHIZUKA
Modified: 2023-07-10 10:50 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (nc)

Attachments
patch to remove unused variable l; (662 bytes, text/plain)
2023-04-09 02:39 UTC, Masachika ISHIZUKA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masachika ISHIZUKA 2023-04-09 02:39:43 UTC 
Created attachment 241361 [details]
patch to remove unused variable l;

% cd /usr/ports/devel/android-tools
% make
(snip)
[ 80% 508/629] /usr/bin/cc -DBORINGSSL_IMPLEMENTATION -I/usr/ports/devel/android-tools/work/freebsd-android-tools-271d7a26c8daf4b9fe412d360a2edfaca327efdd/vendor/boringssl/third_party/googletest/include -I/usr/ports/devel/android-tools/work/freebsd-android-tools-271d7a26c8daf4b9fe412d360a2edfaca327efdd/vendor/boringssl/crypto/../include -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing -Werror -Wformat=2 -Wsign-compare -Wmissing-field-initializers -Wwrite-strings -Wvla -ggdb -Wall -fvisibility=hidden -fno-common -Wnewline-eof -fcolor-diagnostics -Wimplicit-fallthrough -Wmissing-prototypes -Wold-style-definition -Wstrict-prototypes -Wshadow -D_XOPEN_SOURCE=700 -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG -MD -MT vendor/boringssl/crypto/CMakeFiles/crypto.dir/x509/t_x509.c.o -MF vendor/boringssl/crypto/CMakeFiles/crypto.dir/x509/t_x509.c.o.d -o vendor/boringssl/crypto/CMakeFiles/crypto.dir/x509/t_x509.c.o -c /usr/ports/devel/android-tools/work/freebsd-android-tools-271d7a26c8daf4b9fe412d360a2edfaca327efdd/vendor/boringssl/crypto/x509/t_x509.c
FAILED: vendor/boringssl/crypto/CMakeFiles/crypto.dir/x509/t_x509.c.o /usr/ports/devel/android-tools/work/freebsd-android-tools-271d7a26c8daf4b9fe412d360a2edfaca327efdd/vendor/boringssl/crypto/x509/t_x509.c:500:18: error: variable 'l' set but not used [-Werror,-Wunused-but-set-variable]
    int ret = 0, l, i;
                 ^
1 error generated.
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/android-tools
Comment 1 Alastair Hogge 2023-05-09 01:14:54 UTC 
(In reply to Masachika ISHIZUKA from comment #0)

Hello Masachika,

Thanks for the diff, I used it in bug #271321 while updating the port itself to 34.0.0
Comment 2 Olivier Certner freebsd_committer freebsd_triage 2023-05-16 15:11:06 UTC 
Hi,

Didn't see this bug at first, and I've come up with the same diff to fix build on 13-STABLE also.

Regards.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-07-10 10:13:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1e09ad4bcecf67ee0b60c93b4e66ee7111d4c5f1

commit 1e09ad4bcecf67ee0b60c93b4e66ee7111d4c5f1
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2023-07-10 08:28:27 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-07-10 10:13:02 +0000

    devel/android-tools: Remove unused variable

    This is causing -Werror failures with recent Clang builds.

    PR:             270714
    Submitted by:   Masachika ISHIZUKA

 ...ch-vendor_boringssl_crypto_x509_t__x509.c (new) | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
Comment 4 Mikael Urankar freebsd_committer freebsd_triage 2023-07-10 10:50:33 UTC 
thanks!