Bug 270794 - multimedia/kodi-addon-inputstream.adaptive unbreak
Summary: multimedia/kodi-addon-inputstream.adaptive unbreak
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bernhard Froehlich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-12 17:17 UTC by Lars Herschke
Modified: 2023-04-18 09:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (decke)


Attachments
unbreak kodi-addon-inputstream.adaptive (2.63 KB, patch)
2023-04-12 17:17 UTC, Lars Herschke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Herschke 2023-04-12 17:17:28 UTC
Created attachment 241441 [details]
unbreak kodi-addon-inputstream.adaptive

Here is a patch to unbreak kodi-addon-inputstream.adaptive.

The changes in multimedia/Bento4 (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269415) are not useful, because kodi-addon-inputstream.adaptive needs a designated fork of Bento4 to build.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-04-18 09:09:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f980c6e721077a79af0bcfe4d8e5b9548400785c

commit f980c6e721077a79af0bcfe4d8e5b9548400785c
Author:     Lars Herschke <lhersch@dssgmbh.de>
AuthorDate: 2023-04-18 09:08:09 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2023-04-18 09:09:11 +0000

    multimedia/kodi-addon-inputstream.adaptive: Unbreak using forked Bento4

    PR:             270794

 multimedia/kodi-addon-inputstream.adaptive/Makefile          | 11 +++++++----
 multimedia/kodi-addon-inputstream.adaptive/distinfo          |  8 +++++---
 .../files/patch-FindBento4.cmake (new)                       | 12 ++++++++++++
 3 files changed, 24 insertions(+), 7 deletions(-)
Comment 2 Bernhard Froehlich freebsd_committer freebsd_triage 2023-04-18 09:14:39 UTC
I worked on a fix for multimedia/Bento4 but noticed major troubles because Kodi people decided to use a fork with incompatible API. In addition to that their Bento4 fork does not properly build some of their own CLI tools. So there is really no way to use our Bento4 port.

Thanks a lot for the patch, this is really the best (and probably only) way to solve it!