Bug 271125 - news/sabnzbdplus: Update to 4.0.0
Summary: news/sabnzbdplus: Update to 4.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-28 20:21 UTC by Matt
Modified: 2023-05-08 08:31 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (james)
james: maintainer-feedback? (sunpoet)


Attachments
sabnzbd_4.0.0_patch (6.89 KB, patch)
2023-04-28 20:22 UTC, Matt
fuz: maintainer-approval+
Details | Diff
Maintainer: sabnzbdplus 4.0.0 (6.89 KB, patch)
2023-04-29 07:33 UTC, James French
james: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt 2023-04-28 20:21:57 UTC
Notes:
Renamed sabyenc3 to sabctools (renamed upstream)
Renamed sabnzbdplus to sabnzbd (sabnzbdplus has long not been use as the source)

Changes since 3.7.2
In this major update we optimized a core part of the SSL handling.
This results in large performance increases when downloading from news
servers with SSL enabled. In addition, the general connection handling
was improved, resulting in performance improvements for all news servers.
Special thanks to: mnightingale, puzzledsab and animetosho!
There are multiple settings that can tweak performance, see:
#2474
When adding a new news server, SSL is enabled by default.
File assembly performance significantly improved by relying on the
CRC32 instead of the MD5 to perform QuickCheck of files.
Slowdown more gracefully when the cache fills up.
Replaced separate Series/Movie/Date Sorting with general Sorter.
HTTPS files are included in the Backup.
Improved Watched Folder scanning and processing.
Ignore resource fork files created by macOS.
Deobfuscate final filenames is enabled for new installations.
Dropped support for Python 3.7.

Bugfixes since 3.7.2
Restore applying History Retention setting at startup.
Windows: Not all invalid characters were removed from filenames.
Windows: Firewall rules were not removed by uninstaller.
Comment 1 Matt 2023-04-28 20:22:27 UTC
Created attachment 241839 [details]
sabnzbd_4.0.0_patch
Comment 2 James French 2023-04-29 02:52:04 UTC
Thanks for this, the patch looks good, I'll build it this afternoon and approve if there's no issues.

Cheers,
James
Comment 3 James French 2023-04-29 07:33:17 UTC
Created attachment 241845 [details]
Maintainer: sabnzbdplus 4.0.0

This revised patch is approved by me for sabnzbd. PORTEPOCH should never be removed or decremented (anyone with sabnzbd installed will not get the update if the epoch goes backwards).

sunpoet@FreeBSD will have to approve the changes to py-sabyenc3/py-sabctools as I do not maintain that port.

Cheers,
James
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-04-29 12:41:55 UTC
Comment on attachment 241839 [details]
sabnzbd_4.0.0_patch

Maintainer approval has been granted.

The port has been renamed which starts the epoch from the beginning (each package name has its own epoch).  Thus removing PORTEPOCH is correct.
Comment 5 plausible 2023-05-07 22:17:50 UTC
Hey, 
Hate being that kind of a user but anything we users can do to speed this up?
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-05-07 22:30:22 UTC
(In reply to plausible from comment #5)

We are currently waiting for approval from sunpoet@.  If approval is not given within 14 days, the patch may be committed without approval (maintainer timeout).

There's nothing you can do about that unfortunately.  Please don't go and bug sunpoet, he's busy enough as is and will likely have a look at the patch in the next days.
Comment 7 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-05-07 23:04:23 UTC
LGTM except one thing. The LICENSE has been changed/fixed. It is GPLv2+ now.

Reference: https://github.com/sabnzbd/sabctools/issues/86
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-07 23:35:58 UTC
Will commit with changes as indicated by sunpoet.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-05-08 08:27:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c297177504bf33aaf52dc244b77cfa059ed06398

commit c297177504bf33aaf52dc244b77cfa059ed06398
Author:     Matt <lazeraman@gmail.com>
AuthorDate: 2023-05-07 23:44:26 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-08 08:25:52 +0000

    news/sabnzbdplus: update to 4.0.0 and rename to news/sabnzbd

    Changes since 3.7.2
    In this major update we optimized a core part of the SSL handling.
    This results in large performance increases when downloading from news
    servers with SSL enabled. In addition, the general connection handling
    was improved, resulting in performance improvements for all news servers.
    Special thanks to: mnightingale, puzzledsab and animetosho!
    There are multiple settings that can tweak performance, see:
    When adding a new news server, SSL is enabled by default.
    File assembly performance significantly improved by relying on the
    CRC32 instead of the MD5 to perform QuickCheck of files.
    Slowdown more gracefully when the cache fills up.
    Replaced separate Series/Movie/Date Sorting with general Sorter.
    HTTPS files are included in the Backup.
    Improved Watched Folder scanning and processing.
    Ignore resource fork files created by macOS.
    Deobfuscate final filenames is enabled for new installations.
    Dropped support for Python 3.7.

    Bugfixes since 3.7.2
    Restore applying History Retention setting at startup.
    Windows: Not all invalid characters were removed from filenames.
    Windows: Firewall rules were not removed by uninstaller.

    Approved by:    james@french.id.au (maintainer)
    PR:             271125

 MOVED                                                           | 1 +
 news/Makefile                                                   | 2 +-
 news/{sabnzbdplus => sabnzbd}/Makefile                          | 9 ++++-----
 news/sabnzbd/distinfo (new)                                     | 3 +++
 news/{sabnzbdplus => sabnzbd}/files/patch-SABnzbd.py            | 0
 news/{sabnzbdplus => sabnzbd}/files/patch-sabnzbd_newsunpack.py | 0
 news/{sabnzbdplus => sabnzbd}/files/pkg-message.in              | 0
 news/{sabnzbdplus => sabnzbd}/files/sabnzbd.in                  | 0
 news/{sabnzbdplus => sabnzbd}/pkg-descr                         | 0
 news/{sabnzbdplus => sabnzbd}/pkg-plist                         | 0
 news/sabnzbdplus/distinfo (gone)                                | 3 ---
 11 files changed, 9 insertions(+), 9 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-05-08 08:27:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44ebeb5ecc0c9a3e4bb7a4531f816ab6445f756e

commit 44ebeb5ecc0c9a3e4bb7a4531f816ab6445f756e
Author:     Matt <lazeraman@gmail.com>
AuthorDate: 2023-05-07 23:41:29 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-08 08:25:51 +0000

    news/py-sabyenc3: update to 7.0.1 and rename to news/py-sabctools

    This chases a renamed upstream.
    Also chase license clarification to GPLv2+.

    Changelog: https://github.com/sabnzbd/sabctools/releases

    Approved by:    sunpoet (maintainer)
    PR:             271125

 MOVED                                                          |  1 +
 news/Makefile                                                  |  2 +-
 news/{py-sabyenc3 => py-sabctools}/Makefile                    | 10 +++++-----
 news/py-sabctools/distinfo (new)                               |  3 +++
 .../files/patch-src-yencode-crc.cc                             |  0
 .../files/patch-src-yencode-platform.cc                        |  0
 news/{py-sabyenc3 => py-sabctools}/pkg-descr                   |  0
 news/py-sabyenc3/distinfo (gone)                               |  3 ---
 8 files changed, 10 insertions(+), 9 deletions(-)
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-05-08 08:31:55 UTC
Thank you for your contribution.