Bug 271151 - www/icapeg: add new port
Summary: www/icapeg: add new port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-30 18:21 UTC by support
Modified: 2023-05-09 08:33 UTC (History)
4 users (show)

See Also:

Attachments
git patch file (7.84 KB, patch)
2023-04-30 18:21 UTC, support 		no flags Details | Diff
new git patch (2.38 KB, patch)
2023-05-08 16:08 UTC, support 		support: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description support 2023-04-30 18:21:39 UTC 
Created attachment 241888 [details]
git patch file

icap-eg is an implementation of an ICAP server. It can be used with HTTP proxies
that support the ICAP protocol to implement content adaptation and filtering
services.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-02 22:21:19 UTC 
Thank you for your submission.

Please make sure to set "maintainer-approval" on patches you submit.  This makes it more likely for your patch to be looked at.

Please check if you can use GO_MODULE=... instead of manually listing all dependencies.  This can greatly simplify the port.

COMMENT must not start with "An", see § 5.6 Porter's Handbook.

"security" doesn't seem to be an appropriate category for this port.  Perhaps "net"?

Please check and resubmit.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-05-07 00:15:02 UTC 
Additionally use DISTVERSION instead of PORTVERSION and DISTVERSIONPREFIX should be declared before DISTVERSION.

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

There's a pending patch for the first Go(lang) example in Porters Handbook for consistency.
Comment 3 support 2023-05-08 16:08:29 UTC 
Created attachment 242061 [details]
new git patch
Comment 4 support 2023-05-08 16:09:02 UTC 
Hello, patch adjusted as requested, thank you.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-05-08 19:37:29 UTC 
Thank you for your updated submission.

Will likely commit with small formatting changes after testing.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-05-09 08:32:58 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=77182bb119b8985ddb7ef168ef8f4fd1ec824116

commit 77182bb119b8985ddb7ef168ef8f4fd1ec824116
Author:     Khaled Emara <kemara@egirna.com>
AuthorDate: 2023-05-08 16:01:05 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-09 08:27:49 +0000

    www/icapeg: new port

    ICAPeg is an Open Source implementation of ICAP (RFC 3507) server,
    designed to enable web proxies to utilize the function of API based
    services along with standalone executables and databases in order to
    provide content inspection and manipulation services.

    WWW: https://github.com/egirna/icapeg

    PR:             271151
    Reviewed by:    diizzy
    Signed-off-by:  Khaled Emara <kemara@egirna.com>

 www/Makefile               |  1 +
 www/icapeg/Makefile (new)  | 26 ++++++++++++++++++++++++++
 www/icapeg/distinfo (new)  |  5 +++++
 www/icapeg/pkg-descr (new) |  4 ++++
 4 files changed, 36 insertions(+)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-05-09 08:33:50 UTC 
Thank you for your contribution.