Bug 271282 - sysutils/checkrestart: 'make check-plist' finds plist inconsistency
Summary: sysutils/checkrestart: 'make check-plist' finds plist inconsistency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-06 16:54 UTC by John Hein
Modified: 2023-05-08 13:15 UTC (History)
3 users (show)

See Also:
tom: maintainer-feedback+

Attachments
[patch] fix check-plist for sysutils/checkrestart (487 bytes, patch)
2023-05-06 17:00 UTC, John Hein 		tom: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2023-05-06 16:54:43 UTC 
'make -C sysutils/checkrestart stage check-plist' gives:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/periodic/security/checkrestart
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: etc/periodic/security//checkrestart
===> Error: Plist issues found.
*** Error code 1
Comment 1 John Hein 2023-05-06 17:00:39 UTC 
Created attachment 242019 [details]
[patch] fix check-plist for sysutils/checkrestart

It could be argued that check-plist should be smart enough to not be tripped up by one or more extra slashes in a pathname, but this patch just fixes the extra slash in sysutils/checkrestart.  I didn't look at check-plist to see if a fix could be easily implemented there (it probably could).
Comment 2 Thomas Hurst 2023-05-06 19:08:37 UTC 
Comment on attachment 242019 [details]
[patch] fix check-plist for sysutils/checkrestart

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-08 13:15:33 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-05-08 13:15:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73f596c04224b56045bc1b583119ffbd90f8852e

commit 73f596c04224b56045bc1b583119ffbd90f8852e
Author:     Thomas Hurst <tom@hur.st>
AuthorDate: 2023-05-08 09:40:39 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-05-08 13:10:17 +0000

    sysutils/checkrestart: Pacify check-plist

    Fix extra slash.

    PR:             271282
    Reported by:    jcfyecrayz@liamekaens.com (maintainer)

 sysutils/checkrestart/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)