Bug 271395 - mail/mutt: SASL always disabled
Summary: mail/mutt: SASL always disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL: https://bugs.freebsd.org/bugzilla/sho...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-13 20:16 UTC by Derek Schrock
Modified: 2023-05-18 08:28 UTC (History)
2 users (show)

See Also:
dereks: maintainer-feedback+
fuz: merge-quarterly-

Attachments
Fix SASL options (1.28 KB, patch)
2023-05-13 20:16 UTC, Derek Schrock 		dereks: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Derek Schrock 2023-05-13 20:16:54 UTC 
Created attachment 242148 [details]
Fix SASL options

With 60ba31d73e SASL_NONE_CONFIGURE_WITH however with it unchecked --without-sasl was added.  Always disabling sasl no matter the sasl option selected.

Use OPT_CONFIGURE_OFF and OPT_CONFIGURE_ON to make sure --without-sasl isn't added when SASL_NONE is unchecked.


portlint: ok. 1 expected warning. multi patch 
testport: ok. 13amd64.


Building default options we get: ... --with-sasl=/usr/local --without-gsasl ...
and mutt -v: ... +USE_SASL  -USE_GSASL  ... 

Building with GSASL we get: ... --without-sasl --with-gsasl=/usr/local ...
and mutt -v: ... -USE_SASL  +USE_GSASL ...

Building with NONE we get: ... --without-sasl --without-gsasl --with-sasl=no ...
and mutt -v: ... -USE_SASL  -USE_GSASL ...
Comment 1 Derek Schrock 2023-05-13 20:18:23 UTC 
Kurt, can you test this attached patch?
Comment 2 Kurt Hackenberg 2023-05-13 20:43:57 UTC 
Seems to work -- that is, with that one SMTP server, authentication succeeds and sending a message works.
Comment 3 Derek Schrock 2023-05-13 20:47:06 UTC 
Thanks.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-05-17 22:45:52 UTC 
Would you like this change to be merged into the quarterly branch?
Comment 5 Derek Schrock 2023-05-17 23:09:54 UTC 
I don't beleive it would apply to 2023Q2.  It would need the previous commit as well.  So I think don't need to apply it there.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-05-17 23:17:11 UTC 
Thanks.  Will not MFH.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-05-18 08:21:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=37e65e1ec393e94d95f9285501fb9208d475c0cf

commit 37e65e1ec393e94d95f9285501fb9208d475c0cf
Author:     Derek Schrock <dereks@lifeofadishwasher.com>
AuthorDate: 2023-05-13 20:14:46 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-18 08:19:52 +0000

    mail/mutt: Fix SASL option to not always disable SASL

    With 60ba31d73e SASL_NONE_CONFIGURE_WITH however with it unchecked
    --without-sasl was added.  Always disabling sasl.

    Use OPT_CONFIGURE_OFF and OPT_CONFIGURE_ON to make sure --without-sasl
    isn't added when SASL_NONE is unchecked.

    PR:             271395
    Approved by:    kh@panix.com (maintainer)

 mail/mutt/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-18 08:28:32 UTC 
Thank you for your submission.