Created attachment 242184 [details] git diff net-mgmt/nfdump from 1.6.20 to 1.7.2 Many changes, full list on https://github.com/phaag/nfdump/releases Mainly, 1.7 adds: - multi-thread support for flow processing - netflow v9/IPFIX supports flexible length fields - Cisco NBAR support (Cisco Network Based Application Recognition) - Maxmind geo location information - nfpcapd use direct BPF sockets poudriere -t tested and production used…
Created attachment 245763 [details] 1.6.20 to 1.7.3 patch Attached is a patch I had planned to submit (to upgrade to 1.7.3) before seeing this existing bug report. With mine, I was going to suggest maybe [temporally] adding it as a nfdump17 port to allow for net-mgmt/nfsen to be upgraded smoothly. I have also a tentative nfsen 1.3.11 update patch ready to submit, but it would need a 1.7.x nfdump in place first. Notable differences in my patch: - Fixes configure script (which breaks when --disable-xxx is used by FreeBSD ports framework). I don't know if this was broken in 1.7.2. - Includes warning in pkg-message to update pre-1.7 files. - Lacks 1.5 compat option included in 1.7.2 patch.
Created attachment 245936 [details] git patch for net-mgmt/nfdump Hi, happy not to be alone here, but this waits for a while now… Your patch lack geoip option, which is a new 1.7 feature, also misses stripping the new library at install… good catch for the "--without-*" bug, did you reported this upstream ? I reworked the first patch with your fixes, please tell me if this works for you. I think nfsen port being already broken by php version, i wouldn't bother to rename the port… The pkg-message should go to UPDATING file IMHO: Yours, Geoffroy UPDATING proposal: AFFECTS: users of net-mgmt/nfdump nfdump-1.7.x is compatible to nfdump-1.6.18, which means it can read files created with nfdump-1.6.18 or newer. Flow files created with earlier nfdump versions may not contain all flow elements. If you have older files, it is recommended to use nfdump-1.6.17 to update the records. Nfdump 1.7.x provides the same set of programs as 1.6.x and can be used almost as a drop-in replacement. This may change in future and older legacy programs may be removed. You can convert any old files from nfdump-1.6 to nfdump-1.7 format by reading/writing files: ./nfdump -r old-flowfile -y -w new-flowfile Please note, that only nfdump may read older flow files. All other programs relay on the new file format.
for nfsen patch, I also had a 1.3.9 ready, but I think you should fill a new PR, marking this one as "blocking"
Thanks for the patch. I'm a bit busy, but will work on this.
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=33a1d3492cfb451e39017911d919bcc8215a76ff commit 33a1d3492cfb451e39017911d919bcc8215a76ff Author: geoffroy desvernay <dgeo@centrale-med.fr> AuthorDate: 2023-10-28 19:36:18 +0000 Commit: Kurt Jaeger <pi@FreeBSD.org> CommitDate: 2023-10-28 19:36:18 +0000 net-mgmt/nfdump: update 1.6.20 -> 1.7.3 - Check UPDATING for compat with older 1.6.x PR: 271429 Reviewed by: chadf@triularity.org Changes: https://github.com/phaag/nfdump/releases UPDATING | 18 +++++++ net-mgmt/nfdump/Makefile | 53 ++++++------------- net-mgmt/nfdump/distinfo | 6 +-- net-mgmt/nfdump/files/patch-bin_ipfrag.c (gone) | 10 ---- net-mgmt/nfdump/files/patch-configure.ac (new) | 69 +++++++++++++++++++++++++ 5 files changed, 107 insertions(+), 49 deletions(-)
The configure patch has already been committed upstream. I expect it will be included in 1.7.4.