Bug 271503 - multimedia/*pipe-viewer: Update to 0.4.6
Summary: multimedia/*pipe-viewer: Update to 0.4.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL: https://github.com/trizen/pipe-viewer...
Keywords:
: 269607 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-05-19 03:45 UTC by Jesús Daniel Colmenares Oviedo
Modified: 2023-05-21 17:29 UTC (History)
3 users (show)

See Also:


Attachments
pipe-viewer-0.4.6.patch (3.60 KB, patch)
2023-05-19 03:45 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Daniel Colmenares Oviedo 2023-05-19 03:45:38 UTC
Created attachment 242265 [details]
pipe-viewer-0.4.6.patch

Description:

* Add FORK_MANAGER option
* Remove GTK3_USES=desktop-file-utils (.desktop file does not use MimeType)

ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.4.6/Changes

* Fixed the internal extracting of streaming URLs.
* Extended `fat32safe` option to convert Unicode characters to ASCII equivalent when `Text::Unidecode` is available.
* Recognize several more audio itags.

QA:

* portlint:
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [35]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [43]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
  - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
* testport (poudriere: 13.2-RELEASE, amd64, FORK_MANAGER GTK3 JSON_XS LOCAL_CACHE READLINE SHARE_DIR LINE_BREAK YT_DLP tested):
  - Warning: devel/p5-Module-Build was in Perl CORE.  Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL
  - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

Notes:

* Bug 269607 is not needed because this bug removes GTK3_USES=desktop-file-utils.
* I can reproduce the same problem described in issue 168 [1], but it seems not to be directly related to pipe-viewer.

[1] https://github.com/trizen/pipe-viewer/issues/168
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-05-21 14:38:53 UTC
*** Bug 269607 has been marked as a duplicate of this bug. ***
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-05-21 17:27:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=47cc51612f66cc93c339994f66958fd8bff85f7b

commit 47cc51612f66cc93c339994f66958fd8bff85f7b
Author:     Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org>
AuthorDate: 2023-05-19 00:44:56 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-21 17:25:44 +0000

    multimedia/*pipe-viewer: Update to 0.4.6

    * Add FORK_MANAGER option
    * Remove GTK3_USES=desktop-file-utils (.desktop file does not use MimeType)

    ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.4.6/Changes

    * Fixed the internal extracting of streaming URLs.
    * Extended `fat32safe` option to convert Unicode characters to
      ASCII equivalent when `Text::Unidecode` is available.
    * Recognize several more audio itags.

    PR:             271503, 269607

 multimedia/gtk-pipe-viewer/Makefile |  4 ++--
 multimedia/pipe-viewer/Makefile     | 12 +++++++-----
 multimedia/pipe-viewer/distinfo     |  6 +++---
 3 files changed, 12 insertions(+), 10 deletions(-)
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-21 17:29:05 UTC
Thank you for your contribution.