Created attachment 242280 [details] patch for upgrade to version 4.0.1 Upgraded to version 4.0.1 includes patches for Makefile, distinfo, pkg-plist, and a patch for the source code
Thank you for wanting to take this up. Please check you pack list. It now contains a lot of absolute paths, which is incorrect. Paths that are relative to ${PREFIX} must be given as relative paths. You can use "make makeplist" to regenerate the pack list. Your new pack list also no longer conditionally installs plugins and libraries depending on whether the appropriate port options are set. Please check that. An easy way to test if you've done it right is to test with all options off and then with all options on. For each test, run a full build and "make check-plist". Also test with Poudriere if possible. Also please provide a link to the changelog. As is I cannot commit this patch. Please check and resubmit.
Created attachment 242373 [details] updated pkg-plist to reflect your feedback The change log link : http://www.repo.hu/projects/librnd/releases/changelog-4.0.1.txt please give me feedback if you have any other comments, as this is my first time to do this. Thanks for your patience.
Nope. Please check pkg-plist, it's still incorrect in a very obvious place. You can use "make check-plist" to find the problem. Please follow the quality assurance steps given in the Porter's Handbook before submitting a patch.
Created attachment 242394 [details] patch for upgrade to version 4.0.1 fixed the very obvious mistake, thanks for your guidance. I really appreciate it.
Your updated patch too has a problem and does not apply. Please make sure to submit patches unchanged exactly as they come from the diff utility. Ideally, produce them using git-format-patch(1): $ LC_ALL=C git apply --index -p0 <attachment.cgi\?id\=242394 error: patch fragment without header at line 17: @@ -1,3 +1,3 @@ Please check the patch and submit a corrected patch. I'm not sure how you even create these issues.
Created attachment 242522 [details] patch for upgrade to version 4.0.1 I have used Git this time, hope it works ... Thanks for your guidance
Thanks. This patch works. However, it seems like the patch cad/librnd/files/patch-src_librnd_plugins_hid__remote_remote.c does not apply. First it fails due to the presence of hard line breaks. Fixing that, it still no longer applies, apparently because someone has replaced all tabs with spaces. I've manually fixed the patch for now. I've also noticed that pkg-plist is still wrong. Did you run "make check-plist"? Next time, please make sure that the patch you submit actually works. Read the Porter's Handbook for the suggested testing sequence. Make sure to submit patches exactly how they come out of git with no editing of any kind. if submitting from a different computer, transfer the files as binary files. Do not copy/paste them from the terminal, that may destroy tabs and introduce hard line breaks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a56d3b3e9317a7e955f1ae31eed80fbee1668d5b commit a56d3b3e9317a7e955f1ae31eed80fbee1668d5b Author: Hassan El Dallal <hasdalcodes@gmail.com> AuthorDate: 2023-05-31 16:54:25 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-06-01 22:29:22 +0000 cad/librnd: upgrade to 4.0.1 Submitter becomes maintainer. Changelog: http://www.repo.hu/projects/librnd/releases/changelog-4.0.1.txt PR: 271512 cad/librnd/Makefile | 5 +- cad/librnd/distinfo | 6 +- ...h-src_librnd_plugins_hid__remote_remote.c (new) | 11 + cad/librnd/pkg-plist | 564 +++++++++++---------- 4 files changed, 309 insertions(+), 277 deletions(-)
Thank you for your contribution.