Bug 271558 - shells/fish: Update to 3.6.1
Summary: shells/fish: Update to 3.6.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-22 05:29 UTC by Lewis Cook
Modified: 2023-05-23 03:29 UTC (History)
0 users

See Also:
asomers: maintainer-feedback+

Attachments
fish.diff (5.68 KB, patch)
2023-05-22 05:29 UTC, Lewis Cook 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2023-05-22 05:29:00 UTC 
Created attachment 242317 [details]
fish.diff

While here do some minor housekeeping;

* Remove superfluous `post-stage-MANPAGES-off` target, cleanup is already
  handled with PLIST substitutions.

* Collapse the `PORT_OPTIONS` conditional pre-checks back into `DOCS`.  We
  only need sphinx when building the documentation, not `MANPAGES`, as such
  disallow multiple jobs if `DOCS` is enabled.
Comment 1 Alan Somers freebsd_committer freebsd_triage 2023-05-22 14:41:14 UTC 
LGTM.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-05-23 03:28:39 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c35875d80d20b16cbe6673e4cf131a300cd6d015

commit c35875d80d20b16cbe6673e4cf131a300cd6d015
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2023-05-23 03:22:21 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2023-05-23 03:28:18 +0000

    shells/fish: Update to 3.6.1

    While here do some minor housekeeping;

    * Remove superfluous `post-stage-MANPAGES-off` target, cleanup is already
      handled with PLIST substitutions.

    * Collapse the `PORT_OPTIONS` conditional pre-checks back into `DOCS`.  We
      only need sphinx when building the documentation, not `MANPAGES`, as such
      disallow multiple jobs if `DOCS` is enabled.

    Changes:        https://github.com/fish-shell/fish-shell/releases/3.6.1
    PR:             271558
    Approved by:    asomers (maintainer)

 shells/fish/Makefile  | 18 +++++-------------
 shells/fish/distinfo  |  6 +++---
 shells/fish/pkg-plist | 16 ++++++++++++++--
 3 files changed, 22 insertions(+), 18 deletions(-)
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2023-05-23 03:29:29 UTC 
Committed, ta!