Bug 271641 - audio/alsa-plugins: fix build with FFMPEG option enabled
Summary: audio/alsa-plugins: fix build with FFMPEG option enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on: 272337
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-25 19:25 UTC by Martin Neubauer
Modified: 2023-07-08 03:35 UTC (History)
3 users (show)

See Also:


Attachments
Patch fixing build for FFMPEG option (700 bytes, patch)
2023-05-25 19:25 UTC, Martin Neubauer
m.ne: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2023-05-25 19:25:51 UTC
Created attachment 242407 [details]
Patch fixing build for FFMPEG option

After the update to ffmpeg 6 the configure script failed to recognise the components needed, causing packaging errors later on. Changing the dependency to the new ffmpeg4 port fixes this.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-05-29 20:29:17 UTC
Apparently the current release of alsa-plugins works ootb
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-05-30 06:13:27 UTC
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-30 06:13:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca82785515c8ecfa4bab73b7539a688c343f327e

commit ca82785515c8ecfa4bab73b7539a688c343f327e
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2023-05-29 06:40:00 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-05-30 06:08:05 +0000

    audio/alsa-plugins: fix build with FFMPEG option enabled

    After the update to ffmpeg 6 the configure script failed to recognise the
    components needed, causing packaging errors later on. Changing the dependency to
    the new ffmpeg4 port fixes this.

    PR:             271641
    Reported by:    m.ne@gmx.net

 audio/alsa-plugins/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-07 21:33:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df94027c843002a2abe044fa124eb5956a385932

commit df94027c843002a2abe044fa124eb5956a385932
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-07 21:22:40 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-07 21:33:14 +0000

    audio/alsa-plugins: unbreak FFMPEG=on after 685e477b807c

    checking for LIBAV... no
    checking for avcodec_open in -lavcodec... no
    [...]
    configure:13617: checking for LIBAV
    configure:13624: $PKG_CONFIG --exists --print-errors "libavcodec libavutil libavresample"
    Package libavresample was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libavresample.pc'
    to the PKG_CONFIG_PATH environment variable
    Package 'libavresample', required by 'virtual:world', not found
    configure:13627: $? = 1
    [...]
    ====> Checking for pkg-plist issues (check-plist)
    ===> Parsing plist
    ===> Checking for items in STAGEDIR missing from pkg-plist
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    Error: Missing: etc/alsa/conf.d/10-rate-lav.conf
    Error: Missing: etc/alsa/conf.d/60-a52-encoder.conf
    Error: Missing: lib/alsa-lib/libasound_module_pcm_a52.la
    Error: Missing: lib/alsa-lib/libasound_module_pcm_a52.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate.la
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_fast.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_faster.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_high.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_higher.so
    Error: Missing: share/alsa/alsa.conf.d/10-rate-lav.conf
    Error: Missing: share/alsa/alsa.conf.d/60-a52-encoder.conf
    ===> Error: Plist issues found.
    *** Error code 1

    PR:             271641 272337

 audio/alsa-plugins/Makefile | 6 ++++--
 audio/alsa-plugins/distinfo | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-07 21:34:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=38462c18edacfc7e912783cb164065eab8d38be2

commit 38462c18edacfc7e912783cb164065eab8d38be2
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-07 21:02:50 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-07 21:32:45 +0000

    audio/alsa-plugins: revert ffmpeg workaround

    Not a leaf consumer. Depending on ffmpeg4 can cause bustage or crashes
    in ffmpeg consumers.

    PR:             271641 272337

    This reverts commit ca82785515c8ecfa4bab73b7539a688c343f327e.

 audio/alsa-plugins/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-07-07 21:34:54 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b2bad281f662159af0709d978dd5dcb5c375d863

commit b2bad281f662159af0709d978dd5dcb5c375d863
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-07 21:02:50 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-07 21:33:57 +0000

    audio/alsa-plugins: revert ffmpeg workaround

    Not a leaf consumer. Depending on ffmpeg4 can cause bustage or crashes
    in ffmpeg consumers.

    PR:             271641 272337

    This reverts commit ca82785515c8ecfa4bab73b7539a688c343f327e.

    (cherry picked from commit 38462c18edacfc7e912783cb164065eab8d38be2)

 audio/alsa-plugins/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-07-07 21:34:56 UTC
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=210327adb060c183ed7e05d6acf029b93f3bdd8b

commit 210327adb060c183ed7e05d6acf029b93f3bdd8b
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-07-07 21:22:40 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-07-07 21:33:57 +0000

    audio/alsa-plugins: unbreak FFMPEG=on after 685e477b807c

    checking for LIBAV... no
    checking for avcodec_open in -lavcodec... no
    [...]
    configure:13617: checking for LIBAV
    configure:13624: $PKG_CONFIG --exists --print-errors "libavcodec libavutil libavresample"
    Package libavresample was not found in the pkg-config search path.
    Perhaps you should add the directory containing `libavresample.pc'
    to the PKG_CONFIG_PATH environment variable
    Package 'libavresample', required by 'virtual:world', not found
    configure:13627: $? = 1
    [...]
    ====> Checking for pkg-plist issues (check-plist)
    ===> Parsing plist
    ===> Checking for items in STAGEDIR missing from pkg-plist
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    Error: Missing: etc/alsa/conf.d/10-rate-lav.conf
    Error: Missing: etc/alsa/conf.d/60-a52-encoder.conf
    Error: Missing: lib/alsa-lib/libasound_module_pcm_a52.la
    Error: Missing: lib/alsa-lib/libasound_module_pcm_a52.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate.la
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_fast.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_faster.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_high.so
    Error: Missing: lib/alsa-lib/libasound_module_rate_lavrate_higher.so
    Error: Missing: share/alsa/alsa.conf.d/10-rate-lav.conf
    Error: Missing: share/alsa/alsa.conf.d/60-a52-encoder.conf
    ===> Error: Plist issues found.
    *** Error code 1

    PR:             271641 272337
    (cherry picked from commit df94027c843002a2abe044fa124eb5956a385932)

 audio/alsa-plugins/Makefile | 6 ++++--
 audio/alsa-plugins/distinfo | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 8 Tatsuki Makino 2023-07-08 03:35:07 UTC
(In reply to Daniel Engberg from comment #1)
By the way, what is the cause of bug 262089 not progressing?