Bug 271652 - editors/sly: Update to the latest commit (20230523)
Summary: editors/sly: Update to the latest commit (20230523)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-26 12:55 UTC by Olivier Certner
Modified: 2023-05-30 12:32 UTC (History)
1 user (show)

See Also:
olce: maintainer-feedback+


Attachments
Patch (3.84 KB, patch)
2023-05-26 12:57 UTC, Olivier Certner
olce: maintainer-approval+
Details | Diff
Patch (3.85 KB, patch)
2023-05-26 13:03 UTC, Olivier Certner
olce: maintainer-approval+
Details | Diff
Patch (4.14 KB, patch)
2023-05-26 21:52 UTC, Olivier Certner
olce: maintainer-approval+
Details | Diff
Apply with 'git am' (4.62 KB, patch)
2023-05-29 13:08 UTC, Olivier Certner
olce: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Certner freebsd_committer freebsd_triage 2023-05-26 12:55:47 UTC
Hi,

This is a maintainer update.

Patch to be attached after the bug is created.

Thanks and regards.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2023-05-26 12:55:47 UTC
Maintainer informed via mail
Comment 2 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 12:57:36 UTC
Created attachment 242422 [details]
Patch
Comment 3 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 13:03:00 UTC
Created attachment 242423 [details]
Patch

Add the PR number in the commit message.

To apply with 'git am'.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-05-26 20:04:36 UTC
Thank you for your submission.  Do you have a changelog for this update?
Comment 5 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 21:52:33 UTC
Created attachment 242429 [details]
Patch

Changed the commit message to evoke the nature of most changes.

A more precise list would be too long, and probably not that useful.
Comment 6 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 21:53:47 UTC
As per you comment about quarterly policy in another PR, I'm removing the MFH request.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-05-27 08:24:23 UTC
Thanks.  Will commit with my next batch.
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-28 09:46:27 UTC
The patch fails in the check-plist phase:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%THIS_LISPDIR%%/test/sly-package-fu-tests.el
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Please check and resubmit.
Comment 9 Olivier Certner freebsd_committer freebsd_triage 2023-05-29 13:08:47 UTC
Created attachment 242477 [details]
Apply with 'git am'

Thanks for the heads up.  Apparently, DEVELOPER mode doesn't trigger 'check-plist' on its own.

New commit attached.
Comment 10 commit-hook freebsd_committer freebsd_triage 2023-05-29 23:27:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=13a0c17755be629cfdab9c9d711ddbf1081dff1c

commit 13a0c17755be629cfdab9c9d711ddbf1081dff1c
Author:     Olivier Certner <olce.freebsd@certner.fr>
AuthorDate: 2023-05-26 12:35:10 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-29 23:24:17 +0000

    editors/sly: Update to the latest commit (20230523)

    Since no official version has been released since 1.0.43, update to the latest
    commit (after some tests).  Tweak the version number to avoid bumping PORTEPOCH.

    Lots of small changes, including fixes and customization enhancements to the
    REPL, adaptations for future Emacs version, a bunch of fixes for ABCL and clasp.

    Changelog: https://github.com/joaotavora/sly/compare/eb67be96...e6bc13d9

    PR:             271652

 editors/sly/Makefile                 |  4 ++--
 editors/sly/distinfo                 |  6 +++---
 editors/sly/files/patch-doc_Makefile | 11 +----------
 editors/sly/files/patch-doc_sly.texi |  4 ++--
 editors/sly/files/patch-sly.el       |  8 ++++----
 editors/sly/pkg-plist                |  1 +
 6 files changed, 13 insertions(+), 21 deletions(-)
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-05-29 23:28:51 UTC
Thank you for your contribution.
Comment 12 Olivier Certner freebsd_committer freebsd_triage 2023-05-30 12:32:27 UTC
Thanks for committing!

Regards.