Bug 271654 - editors/sly-asdf: Update to the latest version (0.2.0 + 1 one commit)
Summary: editors/sly-asdf: Update to the latest version (0.2.0 + 1 one commit)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-26 13:05 UTC by Olivier Certner
Modified: 2023-05-30 12:33 UTC (History)
1 user (show)

See Also:
olce: maintainer-feedback+
fuz: merge-quarterly+

Attachments
Patch (4.56 KB, patch)
2023-05-26 13:08 UTC, Olivier Certner 		olce: maintainer-approval+
Details | Diff
Patch (4.80 KB, patch)
2023-05-26 22:11 UTC, Olivier Certner 		olce: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Certner freebsd_committer freebsd_triage 2023-05-26 13:05:49 UTC 
Hi,

This is a maintainer update.

Patch to be attached after bug creation.

Thanks and regards.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2023-05-26 13:05:49 UTC 
Maintainer informed via mail
Comment 2 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 13:08:25 UTC 
Created attachment 242425 [details]
Patch
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-05-26 20:07:23 UTC 
Thank you for your submission.  Do you have a changelog for this update?

If upstream has tagged releases, please use the version number and tag name from upstream.  In this case, you can achieve that by removing GH_TAGNAME and then setting

    DISTVERSIONPREFIX= v
    DISTVERSION= 0.2.0

There's no need to manually add a date to the version.  I'm not sure why you did that.
Comment 4 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 22:11:26 UTC 
Created attachment 242432 [details]
Patch

Mention changes in the commit message.
Comment 5 Olivier Certner freebsd_committer freebsd_triage 2023-05-26 22:13:42 UTC 
(In reply to Robert Clausecker from comment #3)

Hi,

Addition of the date is deliberate.  This is because the port doesn't point to the new version, but to the latest commit instead.  I've done this for other ports, and this is what the Porters Handbook seems to recommend for ports that sometimes are based on released versions but sometimes on specific commits (it avoids bumping PORTEPOCH repeatedly).

Thanks.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-05-27 08:28:02 UTC 
Will commit with my next batch and MFH.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-05-29 23:27:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2bc331659d6921f8ac6ebad1429b02d987021494

commit 2bc331659d6921f8ac6ebad1429b02d987021494
Author:     Olivier Certner <olce.freebsd@certner.fr>
AuthorDate: 2023-05-26 12:46:51 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-29 23:24:53 +0000

    editors/sly-asdf: Update to the latest version (0.2.0 + 1 one commit)

    As the port seems to be using explicit versioning, switch to a "version-date"
    scheme and bump PORTEPOCH.

    Changes: A fix for query-replace across a system, a possible ECL fix, fix
    jumping to source for errors.

    Changelog: https://github.com/mmgeorge/sly-asdf/compare/bcaeba9b...6f9d7514

    PR:             271654

 editors/sly-asdf/Makefile                     |  6 +++---
 editors/sly-asdf/distinfo                     |  6 +++---
 editors/sly-asdf/files/patch-README.md (gone) | 16 ----------------
 editors/sly-asdf/files/patch-sly-asdf.el      |  4 ++--
 editors/sly-asdf/pkg-message                  |  8 ++++----
 5 files changed, 12 insertions(+), 28 deletions(-)
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-29 23:34:04 UTC 
Thank you for your contribution.
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-05-29 23:34:21 UTC 
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=daf426a933230f57eabda11909068c9bdb72d882

commit daf426a933230f57eabda11909068c9bdb72d882
Author:     Olivier Certner <olce.freebsd@certner.fr>
AuthorDate: 2023-05-26 12:46:51 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-29 23:33:36 +0000

    editors/sly-asdf: Update to the latest version (0.2.0 + 1 one commit)

    As the port seems to be using explicit versioning, switch to a "version-date"
    scheme and bump PORTEPOCH.

    Changes: A fix for query-replace across a system, a possible ECL fix, fix
    jumping to source for errors.

    Changelog: https://github.com/mmgeorge/sly-asdf/compare/bcaeba9b...6f9d7514

    PR:             271654

    (cherry picked from commit 2bc331659d6921f8ac6ebad1429b02d987021494)

 editors/sly-asdf/Makefile                     |  6 +++---
 editors/sly-asdf/distinfo                     |  6 +++---
 editors/sly-asdf/files/patch-README.md (gone) | 16 ----------------
 editors/sly-asdf/files/patch-sly-asdf.el      |  4 ++--
 editors/sly-asdf/pkg-message                  |  8 ++++----
 5 files changed, 12 insertions(+), 28 deletions(-)
Comment 10 Olivier Certner freebsd_committer freebsd_triage 2023-05-30 12:33:11 UTC 
Thanks for committing!

Regards.