Bug 271719 - multimedia/musikcube: enable MPRIS support via basu by default
Summary: multimedia/musikcube: enable MPRIS support via basu by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-30 03:57 UTC by Jan Beich
Modified: 2023-05-30 04:33 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+

Attachments
v1 (apply via "git am") (3.17 KB, patch)
2023-05-30 03:57 UTC, Jan Beich 		no flags Details | Diff
v1 (apply via "git am") (3.36 KB, patch)
2023-05-30 04:12 UTC, Jan Beich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-05-30 03:57:23 UTC 
Created attachment 242490 [details]
v1 (apply via "git am")

Upstream uses sd-bus library (basu on FreeBSD) to connect to DBus session bus and talk MPRIS protocol.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-05-30 04:01:14 UTC 
Thanks for the patch.
Approved, please commit it.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2023-05-30 04:12:45 UTC 
Created attachment 242491 [details]
v1 (apply via "git am")

Drop option for consistency with other plugins with dependencies (e.g., ffmpegdecoder, libopenmptdecoder, alsaout, sndioout, pipewireout). I'm not sure how to deterministically disable individual plugins after https://github.com/clangen/musikcube/commit/120b6fec0b73 anyway
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-05-30 04:23:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a993ce32573f15593b9f2c31c849320cb3037ce3

commit a993ce32573f15593b9f2c31c849320cb3037ce3
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-05-30 03:20:19 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2023-05-30 04:20:25 +0000

    multimedia/musikcube: enable MPRIS protocol support via basu

    Not a port option for consistency with other plugins.

    PR:             271719
    Approved by:    yuri (maintainer)

 multimedia/musikcube/Makefile  | 16 +++++++++++-----
 multimedia/musikcube/distinfo  |  4 ++++
 multimedia/musikcube/pkg-plist |  1 +
 3 files changed, 16 insertions(+), 5 deletions(-)