Bug 271810 - www/c-icap: Fix invalid integer/pointer conversion while build with llvm15+
Summary: www/c-icap: Fix invalid integer/pointer conversion while build with llvm15+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-03 17:39 UTC by Dima Panov
Modified: 2023-06-17 21:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments
www/c-icap: Fix invalid integer/pointer conversion while build with llvm15+ (4.79 KB, patch)
2023-06-03 17:39 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2023-06-03 17:39:17 UTC
Created attachment 242582 [details]
www/c-icap: Fix invalid integer/pointer conversion while build with llvm15+
Comment 1 Rodrigo Osorio freebsd_committer freebsd_triage 2023-06-15 13:49:20 UTC
Hi Dima,

I suppose the error occurs with llvm16, right ?
How do yo change the llvm version used to compile c-icap in poudriere ?

Chers,
-- rodrigo
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2023-06-15 13:49:20 UTC
Hi Dima,

I suppose the error occurs with llvm16, right ?
How do yo change the llvm version used to compile c-icap in poudriere ?

Chers,
-- rodrigo
Comment 3 Dima Panov freebsd_committer freebsd_triage 2023-06-15 14:08:15 UTC
(In reply to Rodrigo Osorio from comment #2)
yep, tested with llvm15 and llvm16 in poudriere (amd64 and aarch64)

in /usr/local/etc/poudriere.conf

DEFAULT_VERSIONS+=llvm=16
MESA_LLVM_VER=16
VBOX_LLVM_VER=16
LLVM_VER=16
Comment 4 Dima Panov freebsd_committer freebsd_triage 2023-06-15 14:14:15 UTC
(In reply to Rodrigo Osorio from comment #2)
Ah, and all test buildboxes run recent -current with llvm15 in base
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2023-06-15 14:27:35 UTC
(In reply to Dima Panov from comment #4)

Don't see any issue in 13.2-amd64, I will try with 14.0-current and see how it works.

Thanks for your help.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-06-17 21:47:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74d9fa77b3a72e7745f21e5cf3a56557b4f935fd

commit 74d9fa77b3a72e7745f21e5cf3a56557b4f935fd
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2023-06-17 21:21:31 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2023-06-17 21:34:32 +0000

    www/c-icap: Fix invalid integer conversion with llvm15+

    Fix invalid pointer conversion with llvm15+. This issue
    has been corrected previously by asking the compile to ignore
    the errors using CFLAGS -Wno-error=int-conversion.
    This flag is now removed and the errors properly fixed.

    Also fix the some of the paths in the default configuration
    to match the FreeBSD HIER.

    PR:             271810
    Reported by:    fluffy

 www/c-icap/Makefile                         |  5 +----
 www/c-icap/files/patch-c-icap.conf.in       | 27 ++++++++++++++++++++++++++-
 www/c-icap/files/patch-commands.c (new)     | 11 +++++++++++
 www/c-icap/files/patch-mpmt__server.c (new) | 15 +++++++++++++++
 www/c-icap/files/patch-txt__format.c (new)  | 11 +++++++++++
 5 files changed, 64 insertions(+), 5 deletions(-)
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2023-06-17 21:53:20 UTC
Committed with minor changes.

I use PRId64 instead of the int64 -> uint64 conversion you performed,
hope this has no impact in other architectures.
Also remove the CFLAG -Wno-error=int-conversion which is not required anymore
and who hide the int conversion issue for so long.

Thanks for your submission.