Bug 271856 - cad/klayout: Update to 0.28.8
Summary: cad/klayout: Update to 0.28.8
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-06 00:58 UTC by Wen Heping
Modified: 2024-11-28 11:55 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
Update to 0.28.8 (752 bytes, text/plain)
2023-06-06 00:58 UTC, Wen Heping
no flags Details
Patch (1.12 KB, patch)
2024-11-28 07:51 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wen Heping freebsd_committer freebsd_triage 2023-06-06 00:58:52 UTC
Created attachment 242628 [details]
Update to 0.28.8

Update to 0.28.8
Comment 1 Kevin Zheng 2024-11-27 22:39:32 UTC
I tested this patch and 0.28.8 is working for me. Any chance we can get a bump on maintainer feedback for this update?
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-28 02:10:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fc2aacbe520192fe738f74f658d8b4b04ea97626

commit fc2aacbe520192fe738f74f658d8b4b04ea97626
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2024-11-28 02:07:55 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2024-11-28 02:10:10 +0000

    cad/klayout: Update to 0.28.8

    PR:             271856
    Reported by:    wen@
    Approved by:    maintainer(timeout, > 1 year)

 cad/klayout/Makefile | 2 +-
 cad/klayout/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 3 wen 2024-11-28 03:03:36 UTC
(In reply to Kevin Zheng from comment #1)
Upstream released 0.29.8, would you update it ?
Thanks !
Comment 4 Kevin Zheng 2024-11-28 03:33:09 UTC
(In reply to wen from comment #3)
Yes, would be happy to help and take a look.

I do remember taking a look a while back and noticing that updating to 0.29 would require non-trivial changes. I'll give it a shot soon and CC you if there ends up being a PR.
Comment 5 Kevin Zheng 2024-11-28 07:51:03 UTC
Created attachment 255503 [details]
Patch

Wen, Hiroki:

0.28.13 introduced some changes to build.sh which will require some amount of work to make the patch apply cleanly.

However, updating to 0.28.12 is still a trivial version bump. I've tested this version and this seems to work. I've attached a trivial patch that updates to 0.28.12 here.

Given that the changelog (https://github.com/KLayout/klayout/blob/master/Changelog) shows some fixes and enhancements between 0.28.8 and 0.28.12, I think it could be useful to land this version in ports while the latest update is being worked on.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-11-28 11:55:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f68d34075a446749bc7162ecd5dd557b5a22c30

commit 2f68d34075a446749bc7162ecd5dd557b5a22c30
Author:     Wen Heping <wen@FreeBSD.org>
AuthorDate: 2024-11-28 11:46:35 +0000
Commit:     Wen Heping <wen@FreeBSD.org>
CommitDate: 2024-11-28 11:53:56 +0000

    cad/klayout: Update to 0.28.12

    PR:             271856
    Reported by:    kevinz5000@gmail.com
    Approved by:    maintainer(implicit)

 cad/klayout/Makefile | 2 +-
 cad/klayout/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)