Bug 271972 - security/py-fail2ban: More complex path rewrite and small refactoring
Summary: security/py-fail2ban: More complex path rewrite and small refactoring
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-12 21:22 UTC by Dmitry Wagin
Modified: 2023-06-12 22:11 UTC (History)
0 users

See Also:
cy: maintainer-feedback-

Attachments
fail2ban.diff (7.13 KB, patch)
2023-06-12 21:22 UTC, Dmitry Wagin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2023-06-12 21:22:25 UTC 
Created attachment 242751 [details]
fail2ban.diff

More complex path rewrite and small refactoring
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2023-06-12 21:33:02 UTC 
Why would we want to run sed against all the listed files when /etc/fail2ban is not listed in the files?

FAIL2BAN_DBDIR is valid.

Why put the /var/run files somewhere else?
Comment 2 Dmitry Wagin 2023-06-12 21:44:40 UTC 
(In reply to Cy Schubert from comment #1)

> Why would we want to run sed against all the listed files when /etc/fail2ban is not listed in the files?

Look carefully, rewrite not only /etc/fail2ban, also /var/lib/fail2ban, /var/run/fail2ban, jail.conf(5)


> FAIL2BAN_DBDIR is valid.

What you mean?

> Why put the /var/run files somewhere else?

Why not, The ability to configure is good.
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2023-06-12 22:01:01 UTC 
The port already uses FAIL2BAN_DBDIR.

The reason why is tenuous. Why not is not a reason to document why in a commit log message.

The patch is not accepted.
Comment 4 Dmitry Wagin 2023-06-12 22:05:57 UTC 
(In reply to Cy Schubert from comment #3)

If you don't want to accept a patch, clean up the port yourself.

Port is half broken.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-06-12 22:07:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1036c8dcca6e51b2c3dac6b9ebabd42cfc334a90

commit 1036c8dcca6e51b2c3dac6b9ebabd42cfc334a90
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-06-12 22:04:16 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-06-12 22:06:13 +0000

    security/py-fail2ban: Fix FAIL2BAN_DBDIR

    FAIL2BAN_DBDIR is a user set option. Unfortunately plist is not updated
    resulting in plist errors.

    PR:     271972
    MFH:    2023Q2

 security/py-fail2ban/Makefile  | 1 +
 security/py-fail2ban/pkg-plist | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-06-12 22:11:37 UTC 
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0289bca575e831795c0e4c994d154775765b231d

commit 0289bca575e831795c0e4c994d154775765b231d
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-06-12 22:04:16 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-06-12 22:11:09 +0000

    security/py-fail2ban: Fix FAIL2BAN_DBDIR

    FAIL2BAN_DBDIR is a user set option. Unfortunately plist is not updated
    resulting in plist errors.

    PR:     271972

    (cherry picked from commit 1036c8dcca6e51b2c3dac6b9ebabd42cfc334a90)

 security/py-fail2ban/Makefile  | 1 +
 security/py-fail2ban/pkg-plist | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)