Created attachment 242857 [details] trivial update of Makefile and distinfo
Created attachment 242874 [details] Switch to pep517 Sugestion: - Switch to pep517 build (distutils will be deprecated soon): tested OK - Switch to DISTVERSION test target fails in 1.1.1 and 1.1.0, does tests are included in PYPI tarball? There are more than 400 ports using pep517. Thanks
perfect, that looks good, thank you! With regards of the tests, yeah, they should be included in the tarball, but I will check that again
Hi Nuno, I was taking a look at the tarball we can download from pypi, but it doesn't seem to contain tests, which is interesting, since they there in github repo: https://github.com/hvac/hvac Do you recommend disabling tests in the port or downloading the package from elsewhere?
(In reply to Alessandro Sagratini from comment #3) Hello! Thats a good question! When a static tarball is available, its better to use it instead of auto-generated github tarball. Choosing PYPI is the best choice here as MASTER_SITES. If tests not available in PYPI tarball atm, a PR could be opened at upstream asking them to include tests on PYPI. I saw that happened in the past. If upstream refuses that and tests are of big importance, using github tarball is the more correct action to take. My opinion is to remove test target for now and stay stick to PYPI and wait for upstream answer. Cheers
Created attachment 242918 [details] trivial update of Makefile and distinfo
Thanks Nuno for your reply! I opened https://github.com/hvac/hvac/issues/1011 with upstream and uploaded a new patch to this bug report. Let me know if you need anything else
(In reply to Alessandro Sagratini from comment #6) - Adding missing pep517 build dependency: ${PYTHON_PKGNAMEPREFIX}poetry-core>0:devel/py-poetry-core@${PY_FLAVOR} as instructed in ${WRKSRC}/pyproject.toml: [build-system] requires = ["poetry-core>=1.0.0"] build-backend = "poetry.core.masonry.api"
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1d0ec43850087548fc5119daca9fefcfafe85b3c commit 1d0ec43850087548fc5119daca9fefcfafe85b3c Author: Alessandro Sagratini <ale_sagra@hotmail.com> AuthorDate: 2023-06-21 10:23:39 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2023-06-21 10:23:39 +0000 devel/py-hvac: Update to 1.1.1 - Switch to DISTVERSION - Switch to pep517 build - Remove test target because PYPI tarball doesn't include tests: https://github.com/hvac/hvac/issues/1011 ChangeLog: https://github.com/hvac/hvac/blob/v1.1.1/CHANGELOG.md PR: 272060 devel/py-hvac/Makefile | 9 +++------ devel/py-hvac/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 9 deletions(-)
Committed, thanks!