Bug 272104 - net-im/py-matrix-synapse: Update to 1.87.0
Summary: net-im/py-matrix-synapse: Update to 1.87.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-20 20:27 UTC by Li-Wen Hsu
Modified: 2023-08-02 20:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments
v1 (7.00 KB, patch)
2023-06-20 20:27 UTC, Li-Wen Hsu
no flags Details | Diff
v2 (7.35 KB, patch)
2023-07-04 18:22 UTC, Li-Wen Hsu
no flags Details | Diff
net-im/py-matrix-synapse: Update to 1.87.0, fix build issues (8.16 KB, patch)
2023-07-16 17:21 UTC, Sascha Biberhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer freebsd_triage 2023-06-20 20:27:21 UTC
Created attachment 242897 [details]
v1
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2023-07-04 18:22:44 UTC
Created attachment 243204 [details]
v2
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2023-07-05 05:04:43 UTC
===============================================================================
[SKIPPED]
`BaseFederationServlet` does not support cancellation yet.

tests.federation.transport.server.test__base.BaseFederationServletCancellationTests.test_cancellable_disconnect
tests.federation.transport.server.test__base.BaseFederationServletCancellationTests.test_uncancellable_disconnect
===============================================================================
[SKIPPED]
Requires Postgres

tests.handlers.test_presence.PresenceHandlerTestCase.test_external_process_timeout
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_from_syncing_is_set
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_from_syncing_keeps_busy_0
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_from_syncing_keeps_busy_1
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_from_syncing_keeps_status
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_from_syncing_not_set
tests.handlers.test_presence.PresenceHandlerTestCase.test_set_presence_with_status_msg_none
tests.handlers.test_presence.PresenceHandlerTestCase.test_user_goes_offline_by_timeout_status_msg_remain
tests.handlers.test_presence.PresenceHandlerTestCase.test_user_goes_offline_manually_with_no_status_msg
tests.handlers.test_presence.PresenceHandlerTestCase.test_user_goes_offline_manually_with_status_msg
tests.handlers.test_presence.PresenceHandlerTestCase.test_user_reset_online_with_no_status
tests.handlers.test_room_member.TestReplicatedJoinsLimitedByPerRoomRateLimiter.test_local_users_joining_on_another_worker_contribute_to_rate_limit
tests.module_api.test_api.ModuleApiWorkerTestCase.test_send_local_online_presence_to_workers
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_backfilled_redactions
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_get_latest_event_ids_in_room
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_get_rooms_for_user_with_stream_ordering
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_get_rooms_for_user_with_stream_ordering_with_multi_event_persist
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_invites
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_push_actions_for_user_1
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_redactions
tests.replication.storage.test_events.EventsWorkerStoreTestCase.test_push_actions_for_user_0
tests.replication.tcp.streams.test_account_data.AccountDataStreamTestCase.test_update_function_room_account_data_limit
tests.replication.tcp.streams.test_account_data.AccountDataStreamTestCase.test_update_function_global_account_data_limit
tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_backwards_stream_id
tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_event_row_limit
tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_state_row_limit
tests.replication.tcp.streams.test_events.EventsStreamTestCase.test_update_function_huge_state_change
tests.replication.tcp.streams.test_federation.FederationStreamTestCase.test_catchup
tests.replication.tcp.streams.test_partial_state.PartialStateStreamsTestCase.test_un_partial_stated_room_unblocks_over_replication
tests.replication.tcp.streams.test_receipts.ReceiptsStreamTestCase.test_receipt
tests.replication.tcp.streams.test_to_device.ToDeviceStreamTestCase.test_to_device_stream
tests.replication.tcp.streams.test_typing.TypingStreamTestCase.test_typing
tests.replication.tcp.streams.test_typing.TypingStreamTestCase.test_reset
tests.replication.tcp.test_handler.ChannelsTestCase.test_background_worker_subscribed_to_user_ip
tests.replication.tcp.test_handler.ChannelsTestCase.test_non_background_worker_not_subscribed_to_user_ip
tests.replication.tcp.test_handler.ChannelsTestCase.test_wait_for_stream_position
tests.replication.tcp.test_handler.ChannelsTestCase.test_subscribed_to_enough_redis_channels
tests.replication.test_auth.WorkerAuthenticationTestCase.test_authorized
tests.replication.tcp.test_handler.ChannelsTestCase.test_wait_for_stream_position_rdata
tests.replication.test_auth.WorkerAuthenticationTestCase.test_missing_auth
tests.replication.test_auth.WorkerAuthenticationTestCase.test_no_auth
tests.replication.test_client_reader_shard.ClientReaderTestCase.test_register_multi_worker
tests.replication.test_auth.WorkerAuthenticationTestCase.test_unauthorized
tests.replication.test_client_reader_shard.ClientReaderTestCase.test_register_single_worker
tests.replication.test_federation_sender_shard.FederationSenderTestCase.test_send_event_sharded
tests.replication.test_federation_sender_shard.FederationSenderTestCase.test_send_event_single_sender
tests.replication.test_federation_sender_shard.FederationSenderTestCase.test_send_typing_sharded
tests.replication.test_module_cache_invalidation.ModuleCacheInvalidationTestCase.test_module_cache_full_invalidation
tests.replication.test_multi_media_repo.MediaRepoShardTestCase.test_basic
tests.replication.test_multi_media_repo.MediaRepoShardTestCase.test_download_image_race
tests.replication.test_multi_media_repo.MediaRepoShardTestCase.test_download_simple_file_race
tests.replication.test_pusher_shard.PusherShardTestCase.test_send_push_multiple_workers
tests.replication.test_pusher_shard.PusherShardTestCase.test_send_push_single_worker
tests.replication.test_sharded_event_persister.EventPersisterShardTestCase.test_vector_clock_token
tests.replication.test_sharded_event_persister.EventPersisterShardTestCase.test_basic
tests.storage.test_id_generators.BackwardsMultiWriterIdGeneratorTestCase.test_multiple_instance
tests.storage.test_id_generators.BackwardsMultiWriterIdGeneratorTestCase.test_single_instance
tests.storage.test_id_generators.MultiTableMultiWriterIdGeneratorTestCase.test_load_existing_stream
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_empty
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_get_next_txn
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_get_persisted_upto_position
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_get_persisted_upto_position_get_next
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_multi_instance
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_out_of_order_finish
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_restart_during_out_of_order_persistence
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_sequence_consistency
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_single_instance
tests.storage.test_id_generators.MultiWriterIdGeneratorTestCase.test_writer_config_change
tests.storage.test_unsafe_locale.UnsafeLocaleTest.test_safe_locale
tests.storage.test_unsafe_locale.UnsafeLocaleTest.test_unsafe_locale
===============================================================================
[SKIPPED]
Requires jaeger_client

tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_nested_spans
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_overlapping_spans
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_start_active_span
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_async
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_awaitable_return
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_deferred
tests.logging.test_opentracing.LogContextScopeManagerTestCase.test_trace_decorator_sync
===============================================================================
[SKIPPED]
Test only applies when postgres is used as the database

tests.storage.test_room_search.MessageSearchTest.test_postgres_web_search_for_phrase
===============================================================================
[SKIPPED]
Requires PyICU

tests.storage.test_user_directory.UserDirectoryICUTestCase.test_icu_word_boundary
tests.storage.test_user_directory.UserDirectoryICUTestCase.test_icu_word_boundary_punctuation
tests.storage.test_user_directory.UserDirectoryICUTestCase.test_regex_word_boundary_punctuation
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_all_users
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_ascii_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_start_of_user_id
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_stop_words
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_unicode_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_unicode_normalization
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_limit_correct
===============================================================================
[SKIPPED]
not supported yet

tests.storage.test_user_directory.UserDirectoryStoreTestCase.test_search_user_dir_accent_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_accent_insensitivity
===============================================================================
[SKIPPED]
not supported

tests.storage.test_user_directory.UserDirectoryStoreTestCase.test_search_user_dir_dotted_dotless_i_case_insensitivity
tests.storage.test_user_directory.UserDirectoryStoreTestCaseWithIcu.test_search_user_dir_dotted_dotless_i_case_insensitivity
-------------------------------------------------------------------------------
Ran 2815 tests in 118.046s

PASSED (skips=95, successes=2720)
Comment 3 Sascha Biberhofer 2023-07-16 17:21:33 UTC
Created attachment 243424 [details]
net-im/py-matrix-synapse: Update to 1.87.0, fix build issues

I've reviewed and tested the diff, which looks good to me, passes the test suite and apparently refrains from causing any issues, if the last 24h are anything to go on. So I fully approve this update.

With the update of py-pillow and poetry-core hitting ports, I'd like to combine this with #272488 to backport a fix for py-pillow and bump the ranges for poetry-core. I've discussed the latter change with upstream for confirmation that this should be fine as the upper bound is in place as a precaution only.

I've attached a patch combining these changes, which works just as fine as the original update and unbreaks py-matrix-synapse.
Comment 4 Li-Wen Hsu freebsd_committer freebsd_triage 2023-07-18 04:01:10 UTC
(In reply to Sascha Biberhofer from comment #3)

Thanks. I'll commit your version soon after testing.

What do you mean by #272488? It's unlikely bug272488 since it seems unrelated.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-20 07:02:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=25ae04fe067204bd26e3b114ce58763202b4f4a3

commit 25ae04fe067204bd26e3b114ce58763202b4f4a3
Author:     Sascha Biberhofer <ports@skyforge.at>
AuthorDate: 2023-07-19 01:39:14 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2023-07-20 07:01:30 +0000

    net-im/py-matrix-synapse: Update to 1.87.0

    PR:             272104
    Co-authored-by: Li-Wen Hsu <lwhsu@FreeBSD.org>

 net-im/py-matrix-synapse/Makefile                  |  5 ++-
 net-im/py-matrix-synapse/Makefile.crates           | 16 ++++-----
 net-im/py-matrix-synapse/distinfo                  | 38 +++++++++++-----------
 .../files/patch-synapse_media_thumbnailer.py (new) | 11 +++++++
 4 files changed, 40 insertions(+), 30 deletions(-)
Comment 6 Sascha Biberhofer 2023-07-23 15:10:31 UTC
(In reply to Li-Wen Hsu from comment #4)
Sorry for the typo in the bug reference. :/

I meant https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272448

Since this is committed, I think we can close both issues.