Bug 272154 - audio/sidplayfp: Various improvements
Summary: audio/sidplayfp: Various improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-22 22:48 UTC by Daniel Engberg
Modified: 2023-06-23 06:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
Patch for sidplayfp (2.25 KB, patch)
2023-06-22 22:48 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-06-22 22:48:22 UTC 
Created attachment 242940 [details]
Patch for sidplayfp

* PORTVERSION --> DISTVERSION
* Use upstream release tarball instead of USE_GITHUB as recommened by Porters Handbook
* Remove USES= iconv, works fine without any helpers
* Add USES= compiler:c++17-lang
* Make ALSA and Pulseaudio audio backends optional
* Use out123 by default to reduce dependencies

Poudriere testport OK 13.2-RELEASE (amd64)
Comment 1 Emanuel Haupt freebsd_committer freebsd_triage 2023-06-23 06:59:39 UTC 
Committed, thanks.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-06-23 06:59:49 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f5c5e5dff785428e1490ff58ff452aca10ce80a

commit 4f5c5e5dff785428e1490ff58ff452aca10ce80a
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2023-06-23 06:59:19 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2023-06-23 06:59:19 +0000

    audio/sidplayfp: Various improvements

    * PORTVERSION --> DISTVERSION
    * Use upstream release tarball instead of USE_GITHUB
    * Remove USES= iconv, works fine without any helpers
    * Add USES= compiler:c++17-lang
    * Make ALSA and Pulseaudio audio backends optional

    PR:             272154
    Reported by:    diizzy

 audio/sidplayfp/Makefile | 27 +++++++++++++++++----------
 audio/sidplayfp/distinfo |  6 +++---
 2 files changed, 20 insertions(+), 13 deletions(-)