Bug 272160 - security/openssl30: installation fails when OPTION FIPS is disabled
Summary: security/openssl30: installation fails when OPTION FIPS is disabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-23 10:41 UTC by Michael Osipov
Modified: 2023-09-19 18:29 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
Full poudriere log (110.85 KB, application/x-gzip)
2023-09-19 15:21 UTC, Michael Osipov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2023-06-23 10:41:19 UTC
Running on FreeBSD 12-STABLE.

I have disabled FIPS and poudriere tells me:
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%OPENSSLDIR%%/fipsmodule.cnf
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/security/openssl30
=>> Error: check-plist failures detected


One needs to check which FIPS files are actually installed when FIPS is disabled.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2023-09-16 12:19:16 UTC
Just checked, this doesn't occur in my build
Comment 2 Michael Osipov 2023-09-16 12:35:16 UTC
Let me try to reproduce this again.
Comment 3 Michael Osipov 2023-09-16 13:10:56 UTC
Still does not work for me with
commit e662f3927a40023074fb2868916474ed71ea0e2d (origin/main, origin/HEAD)
Author: Baptiste Daroussin <bapt@FreeBSD.org>
Date:   2023-09-15T11:07:21+02:00

# poudriere testport -j 124-release-amd64 -p default-head -z openssl30 security/openssl30

Result:
/usr/bin/strip /wrkdirs/usr/ports/security/openssl30/work/stage/usr/local/bin/openssl
( cd /wrkdirs/usr/ports/security/openssl30/work/stage//usr/local ; find man/man3 -not -type d ;  find man/man7 -not -type d ) | sed 's/$/.gz/' >> /wrkdirs/usr/ports/security/openssl30/work/.PLIST.mktmp
====> Compressing man pages (compress-man)
===========================================================================
====> Running Q/A tests (stage-qa)
Warning: you need USES=ssl
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: @dir lib/ossl-modules
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%OPENSSLDIR%%/fipsmodule.cnf
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/security/openssl30
=>> Error: check-plist failures detected
build of security/openssl30 | openssl30-3.0.10 ended at Sat Sep 16 15:08:26 CEST 2023
build time: 00:02:11
!!! build failure encountered !!!
[00:07:28] Error: Build failed in phase: check-plist
[00:07:28] Logs: /var/poudriere/data/logs/bulk/124-release-amd64-default-head-openssl30/2023-09-16T15:00:58
[00:07:28] Cleaning up
[00:07:28] Unmounting file systems
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2023-09-19 14:45:31 UTC
Pls share full poudriere testport log
Comment 5 Michael Osipov 2023-09-19 15:21:55 UTC
Created attachment 245025 [details]
Full poudriere log

Here it is
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-09-19 17:06:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba2b345bc86f19697e03bbeee3b006645706701f

commit ba2b345bc86f19697e03bbeee3b006645706701f
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2023-09-19 17:02:38 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2023-09-19 17:02:38 +0000

    security/openssl30: Fix modules options

    PR:             272160
    Reported by:    Michael Osipov <michael osipov siemens com>

 security/openssl30/Makefile  | 2 +-
 security/openssl30/pkg-plist | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-19 17:06:48 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2da65de98bfc9ff5940124b73c2fba95fe6d1580

commit 2da65de98bfc9ff5940124b73c2fba95fe6d1580
Author:     Bernard Spil <brnrd@FreeBSD.org>
AuthorDate: 2023-09-19 17:04:47 +0000
Commit:     Bernard Spil <brnrd@FreeBSD.org>
CommitDate: 2023-09-19 17:04:47 +0000

    security/openssl31: Update to 3.1.3

     * Fix modules options[1]

    PR:             272160
    Reported by:    Michael Osipov <michael osipov siemens com>

 security/openssl31/Makefile  | 4 ++--
 security/openssl31/distinfo  | 6 +++---
 security/openssl31/pkg-plist | 3 ++-
 3 files changed, 7 insertions(+), 6 deletions(-)
Comment 8 Bernard Spil freebsd_committer freebsd_triage 2023-09-19 17:09:04 UTC
Totally misread your report. There was more breakage when both modules were disabled, also addressed.

Thanks for your patience Michael!
Comment 9 Michael Osipov 2023-09-19 18:29:44 UTC
(In reply to Bernard Spil from comment #8)

This one looks good. Thanks!