Bug 272167 - print/cups: Use upstream release tarball
Summary: print/cups: Use upstream release tarball
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-23 18:07 UTC by Daniel Engberg
Modified: 2023-07-11 20:22 UTC (History)
1 user (show)

See Also:
tijl: maintainer-feedback+


Attachments
Patch for cups (1.29 KB, patch)
2023-06-23 18:07 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-06-23 18:07:39 UTC
Created attachment 242956 [details]
Patch for cups

As recommened by Porters Handbook use release tarball instead of using USE_GITHUB

Tested on 13.2-RELEASE (amd64)
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2023-06-23 18:32:20 UTC
Ok, but maybe use DISTVERSIONSUFFIX=-source instead of DISTNAME?
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-06-23 20:25:19 UTC
I would say no as it's not a part of the "version name" imo but the filename itself however looking at "Example 7. Using DISTVERSION" I guess it's up to the maintainer to decide. If we're going to be picky about style PORTVERSION should also be DISTVERSION (I missed that when I generated the patch).
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2023-06-25 15:58:30 UTC
(In reply to Daniel Engberg from comment #2)
Okay, how about DISTVERSION=2.4.6 and EXTRACT_SUFX=-source.tar.gz?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-06-25 17:41:29 UTC
That works but Porters Handbook suggests that using it that way is misusing the variable. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-extract_sufx
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-11 20:20:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=21e620488c1e545a0af680a7c5d1aecc50fd04ce

commit 21e620488c1e545a0af680a7c5d1aecc50fd04ce
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2023-06-25 16:01:29 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2023-07-11 20:10:57 +0000

    print/cups: Use upstream release tarball

    PR:             272167

 print/cups/Makefile | 8 +++-----
 print/cups/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 8 deletions(-)