Created attachment 242967 [details] Patch for flac * Switch to CMake, builds faster and generates .cmake files for consumers * Enable testing when running as root Compile and runtime tested on FreeBSD 13.2-RELEASE (aarch64) (make, make check-plist, make test) Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test) Poudriere testport OK 13.2-RELEASE (aarch64) Tested with following consumers in 12.4-RELEASE (amd64) using Poudriere: audio/alure audio/aqualung audio/ardour audio/audacity audio/audiocd-kio audio/deadbeef audio/easytag audio/flac123 audio/gmtp audio/gogglesmm audio/gstreamer1-plugins-flac audio/gtkpod audio/harp audio/kid3 audio/kwave audio/libaudiofile audio/libfishsound audio/libmp3splt audio/libopenmpt audio/libsndfile audio/lmms audio/mixxx audio/mixxx22 audio/moc audio/mous audio/musicpd audio/mythplugin-mythmusic audio/noson-app audio/ocp audio/opus-tools audio/p5-Audio-FLAC-Header audio/polyphone audio/rezound audio/sdl2_mixer audio/sdl_audiolib audio/sdl_mixer audio/sdl_sound audio/sonic-visualiser audio/sox audio/squash audio/squeezelite audio/tagutil audio/traverso audio/twolame audio/vorbis-tools audio/xmcd devel/allegro5 devel/aws-sdk-cpp devel/electron19 devel/electron21 devel/electron22 devel/electron23 devel/electron24 devel/sfml editors/vscode emulators/mame emulators/vice games/NBlood games/eduke32 games/openrct2 games/vkquake multimedia/audacious-plugins multimedia/butt multimedia/libxine multimedia/mkvtoolnix multimedia/musikcube multimedia/qmmp-qt5 multimedia/qmmp-qt6 multimedia/snapcast net/minidlna net-im/signal-desktop sysutils/fusefs-mp3fs sysutils/k3b sysutils/tracker-miners textproc/libextractor textproc/obsidian (not built due to EULA) www/chromium www/iridium www/ungoogled-chromium games/scummvm-tools
Committed. Thanks for the patch, Daniel!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f7f2d731c8d9a0cdfce89950e2d387dc07909e30 commit f7f2d731c8d9a0cdfce89950e2d387dc07909e30 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-06-25 15:56:39 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2023-06-25 15:57:35 +0000 audio/flac: Update 1.4.2 → 1.4.3 PR: 272185 audio/flac/Makefile | 47 +++++++++++++++------------------ audio/flac/distinfo | 6 ++--- audio/flac/files/patch-configure (gone) | 13 --------- audio/flac/pkg-plist | 11 +++++--- 4 files changed, 32 insertions(+), 45 deletions(-)
https://cgit.freebsd.org/ports/commit/?id=903973f2f5ddd19fd5c6279de92dee571d1d4351
Sorry about not noticing the maintainer. My mistake. I am not quire sure why am I CCed on this.
I initially by mistake added the URL in Summary which made Bugzilla send out mail to a bunch of people, sorry about that.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7a00365c6911b28d5cd5567cda82b086e21423ef commit 7a00365c6911b28d5cd5567cda82b086e21423ef Author: Christian Weisgerber <naddy@FreeBSD.org> AuthorDate: 2023-06-26 20:23:31 +0000 Commit: Christian Weisgerber <naddy@FreeBSD.org> CommitDate: 2023-06-26 20:26:21 +0000 audio/flac: update to 1.4.3 Improve the flac tool's handling of foreign metadata on decoding a file (i.e. restoring the foreign metadata) and add a few features to the metaflac tool. Both tools have been vetted with fuzzing, resulting in numerous small fixes. All PowerPC-specific code has been removed. PR: 272185 audio/flac/Makefile | 12 ++++-------- audio/flac/distinfo | 6 +++--- audio/flac/files/patch-configure | 14 +++++++------- audio/flac/pkg-plist | 4 ++-- 4 files changed, 16 insertions(+), 20 deletions(-)
I committed my own update to 1.4.3. I did not switch the build system, and there has been no change to the tests: they would still fail if run as root.
Tests runs fine however it skips ones for libflac Test project /usr/ports/audio/flac/work/.build Start 1: grabbag 1/8 Test #1: grabbag .......................... Passed 0.13 sec Start 2: generate_streams 2/8 Test #2: generate_streams ................. Passed 1.80 sec Start 3: flac 3/8 Test #3: flac ............................. Passed 4.99 sec Start 4: metaflac 4/8 Test #4: metaflac ......................... Passed 0.47 sec Start 5: replaygain 5/8 Test #5: replaygain ....................... Passed 0.53 sec Start 6: seeking 6/8 Test #6: seeking .......................... Passed 0.47 sec Start 7: streams 7/8 Test #7: streams .......................... Passed 306.95 sec Start 8: compression 8/8 Test #8: compression ...................... Passed 2.50 sec 100% tests passed, 0 tests failed out of 8 Total Test time (real) = 317.85 sec