Bug 272242 - audio/mkcue: fix build with c++17
Summary: audio/mkcue: fix build with c++17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-27 07:23 UTC by Tobias Rehbein
Modified: 2023-06-29 06:38 UTC (History)
1 user (show)

See Also:

Attachments
Patch to fix the build for audio/mkcue with c++17 (797 bytes, patch)
2023-06-27 07:23 UTC, Tobias Rehbein 		fernape: maintainer-approval+
tobias.rehbein: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Rehbein 2023-06-27 07:23:48 UTC 
Created attachment 243032 [details]
Patch to fix the build for audio/mkcue with c++17

Reported by: pkg-fallout
Poudriere: Ok (amd64 14.0 Current; amd64 13.2-RELEASE)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-28 09:56:54 UTC 
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.


Thanks!
Comment 2 Tobias Rehbein 2023-06-28 11:20:35 UTC 
Understood. Thanks for taking a look at the PR and pointing these issues out.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-06-29 06:38:24 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-06-29 06:38:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a8841b927607b2e1756918ff6154085c54fa7824

commit a8841b927607b2e1756918ff6154085c54fa7824
Author:     Tobias Rehbein <tobias.rehbein@web.de>
AuthorDate: 2023-06-28 09:57:12 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-06-29 06:37:55 +0000

    audio/mkcue: fix build with c++17

    PR:             272242
    Reported by:    tobias.rehbein@web.de (maintainer)

 audio/mkcue/files/patch-diskid.h (new) | 13 +++++++++++++
 1 file changed, 13 insertions(+)