Created attachment 243152 [details] patch: fs-uae build fix on clang 16 Fixes build errors due to clang 16 changes. src/archivers/dms/crc_csum.cpp:61:2: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] register USHORT CRC = 0; ^~~~~~~~~ 1 error generated.
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Would it be possible to patch the 'register' keyword out instead of setting an older standard? Thanks!
Don't know, I just used the same solution as PR 271415, PR 271353 and PR 271424.
>Would it be possible to patch the 'register' keyword out instead of setting an older standard? Had a quick try, patched out two but there's loads more in other parts of the code. Fix one of those and a few more show up. The USE_CXXSTD seems the cleanest and simplest solution. I had seen another solution in bug #271870 CPPFLAGS+= -Dregister= That does fix the issue here too. But it looks a bit dodgy. Let me know which solution you prefer and I'll change it.
(In reply to sirdice from comment #3) OK, let's go for the one that is attached. Thanks for double checking.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a4987a77fce51447c3fe026d2c297570ee206d04 commit a4987a77fce51447c3fe026d2c297570ee206d04 Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2023-07-03 06:46:21 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-07-04 15:10:43 +0000 emulators/fs-uae: fixes build error on clang 16. PR: 272336 Reported by: sirdice@gmail.com (maintainer) emulators/fs-uae/Makefile | 1 + 1 file changed, 1 insertion(+)