Bug 272497 - math/libdivide: Add NATIVE option
Summary: math/libdivide: Add NATIVE option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-14 08:23 UTC by Yuri Victorovich
Modified: 2023-07-21 08:05 UTC (History)
0 users

See Also:
thierry: maintainer-feedback+

Attachments
patch (1.35 KB, patch)
2023-07-14 08:23 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2023-07-14 08:23:50 UTC 
Created attachment 243381 [details]
patch

By default the project builds with -march=native, which potentially causes illegal instruction errors.

The attached patch removes this flag by default.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2023-07-20 09:16:39 UTC 
Approved, thanks!
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-07-21 08:03:00 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-07-21 08:04:07 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8bafc25ae4f48be3af984c4be1b9cd0d7a181350

commit 8bafc25ae4f48be3af984c4be1b9cd0d7a181350
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-07-21 07:56:35 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-07-21 08:03:10 +0000

    math/libdivide: Add NATIVE option

    PR:             272497
    Approved by:    thierry@ (maintainer)

 math/libdivide/Makefile                   | 5 +++++
 math/libdivide/files/patch-CMakeLists.txt | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-21 08:05:09 UTC 
A commit in branch 2023Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4ab93272f7909c0fb11d8110519b32c141fff4c6

commit 4ab93272f7909c0fb11d8110519b32c141fff4c6
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2023-07-21 07:56:35 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-07-21 08:04:14 +0000

    math/libdivide: Add NATIVE option

    PR:             272497
    Approved by:    thierry@ (maintainer)

    (cherry picked from commit 8bafc25ae4f48be3af984c4be1b9cd0d7a181350)

 math/libdivide/Makefile                   | 5 +++++
 math/libdivide/files/patch-CMakeLists.txt | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)