Bug 272516 - security/rkhunter: Modernize and correct the periodic script
Summary: security/rkhunter: Modernize and correct the periodic script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-15 13:10 UTC by Helge Oldach
Modified: 2023-07-28 06:32 UTC (History)
3 users (show)

See Also:
lukasz: maintainer-feedback+

Attachments
patch (3.70 KB, patch)
2023-07-15 13:10 UTC, Helge Oldach 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2023-07-15 13:10:13 UTC 
Created attachment 243403 [details]
patch

security/rkhunter's periodic script falls into the "security" category but follows pre-stable/12 variable naming conventions. Thus, it's meant to run daily but runs weekly and monthly as well.

Modernize the script but use a compatibility shim to maintain previous variables.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-27 06:42:06 UTC 
Since the binary package will be (slightly) different, we need to bump PORTREVISION. No need to update a new patch.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-28 06:31:59 UTC 
Committed,

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-07-28 06:32:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c85caa3933d08274a9ba9b1be16ee8af5583b99a

commit c85caa3933d08274a9ba9b1be16ee8af5583b99a
Author:     Helge Oldach <freebsd@oldach.net>
AuthorDate: 2023-07-27 06:42:27 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-07-28 06:31:32 +0000

    security/rkhunter: Modernize and correct the periodic script

    Modernize the script but use a compatibility shim to maintain previous
    variables.

    PR:             272516
    Reported by:    freebsd@oldach.net
    Approved by:    lukasz@wasikowski.net (maintainer)

 security/rkhunter/Makefile              |  2 +-
 security/rkhunter/files/415.rkhunter.in | 67 ++++++++++++++++-----------------
 security/rkhunter/pkg-message           | 10 +++--
 3 files changed, 40 insertions(+), 39 deletions(-)