Bug 272550 - graphics/osgearth: Update to 3.4
Summary: graphics/osgearth: Update to 3.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Felix Palmen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-17 17:38 UTC by Felix Palmen
Modified: 2023-07-20 16:39 UTC (History)
1 user (show)

See Also:
zirias: maintainer-feedback+


Attachments
0001-graphics-osgearth-Update-to-3.4 (11.75 KB, patch)
2023-07-17 17:38 UTC, Felix Palmen
no flags Details | Diff
0001-graphics-osgearth-Update-to-3.4 (11.75 KB, patch)
2023-07-17 17:42 UTC, Felix Palmen
no flags Details | Diff
0001-graphics-osgearth-Update-to-3.4 (v2) (11.45 KB, patch)
2023-07-18 10:02 UTC, Felix Palmen
no flags Details | Diff
0001-graphics-osgearth-Update-to-3.4 (v3) (11.86 KB, patch)
2023-07-20 16:26 UTC, Felix Palmen
lbartoletti: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen freebsd_committer freebsd_triage 2023-07-17 17:38:58 UTC
Created attachment 243437 [details]
0001-graphics-osgearth-Update-to-3.4

Having just committed a build fix for osgearth (because it popped up in ports depending on devel/poco, so I just wanted to bump it, but learned it doesn't build currently), I also noticed it's a bit outdated ...

Therefore, please find attached a commit (format for 'git am') to update it to the latest upstream release 3.4, kindly asking for review, thanks :)

Cheers, Felix
Comment 1 Felix Palmen freebsd_committer freebsd_triage 2023-07-17 17:42:40 UTC
Created attachment 243438 [details]
0001-graphics-osgearth-Update-to-3.4

Eliminate accidentally blank line :o
Comment 2 Felix Palmen freebsd_committer freebsd_triage 2023-07-18 10:02:49 UTC
Created attachment 243459 [details]
0001-graphics-osgearth-Update-to-3.4 (v2)

Test build on i386 (which took forever because of gcc12...) revealed the extra patch is still needed here, so re-integrate and update it.
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2023-07-20 14:29:58 UTC
Thanks, not tested and not time these days.

Do you want to take maintainer ship of this port? If yes, go ahaed, if no, please drop my maintainer ship on it.
Comment 4 Felix Palmen freebsd_committer freebsd_triage 2023-07-20 16:26:52 UTC
Created attachment 243508 [details]
0001-graphics-osgearth-Update-to-3.4 (v3)

(In reply to Loïc Bartoletti from comment #3)

Ok then, I guess I could take this one. Please just approve the updated patch to confirm passing maintainership, thanks!
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2023-07-20 16:34:16 UTC
Comment on attachment 243508 [details]
0001-graphics-osgearth-Update-to-3.4 (v3)

Approved, Thanks to you!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-07-20 16:38:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=10327d204ee8740ba8cf5b11e59084c85279ce3a

commit 10327d204ee8740ba8cf5b11e59084c85279ce3a
Author:     Felix Palmen <zirias@FreeBSD.org>
AuthorDate: 2023-07-16 18:56:56 +0000
Commit:     Felix Palmen <zirias@FreeBSD.org>
CommitDate: 2023-07-20 16:37:12 +0000

    graphics/osgearth: Update to 3.4

    Changes from 3.2: Bugfixes, performance and maintenance, see
    https://github.com/gwaldron/osgearth/releases

    Take maintainership from lbartoletti@.

    PR:             272550
    Approved by:    lbartoletti (previous maintainer)

 graphics/osgearth/Makefile                         | 18 ++++++-----
 graphics/osgearth/distinfo                         | 12 ++++++--
 graphics/osgearth/files/extra-patch-i386           |  8 ++---
 graphics/osgearth/files/patch-CMakeLists.txt (new) |  8 +++++
 .../patch-src_osgEarthDrivers_lerc_CMakeLists.txt  |  6 ++--
 graphics/osgearth/pkg-plist                        | 35 +++++++++++-----------
 6 files changed, 53 insertions(+), 34 deletions(-)
Comment 7 Felix Palmen freebsd_committer freebsd_triage 2023-07-20 16:39:05 UTC
Thanks, it's pushed :)