Bug 272558 - mail/xmail: Time to delete port
Summary: mail/xmail: Time to delete port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-17 22:41 UTC by sjrbulk
Modified: 2023-07-18 15:01 UTC (History)
4 users (show)

See Also:


Attachments
Assume maintainership. (389 bytes, patch)
2023-07-18 05:24 UTC, Cy Schubert
sjroz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sjrbulk 2023-07-17 22:41:01 UTC
mail/xmail is failing to build on FreeBSD-14. Since this was originally written in 1995 and hasn't been maintained in a long time - last FreeBSD updates were in 2007 - this is probably a good candidate for removal.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-07-18 03:54:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=093a84fae0a83312bfc6b335bb0a56bb6b004a04

commit 093a84fae0a83312bfc6b335bb0a56bb6b004a04
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2023-07-18 03:52:26 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2023-07-18 03:52:26 +0000

    mail/xmail: Deprecate and set expiration date to 2023-09-30

    mail/xmail is failing to build on FreeBSD-14. Since this was originally
    written in 1995 and hasn't been maintained in a long time - last FreeBSD
    updates were in 2007 - this is probably a good candidate for removal.

    PR:             272558

 mail/xmail/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2023-07-18 03:55:48 UTC
Deprecated the port. Thanks for your contribution!
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 05:16:38 UTC
Do you mind if I take on maintainership?
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 05:17:17 UTC
Pending approval to take maintainership.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-07-18 05:21:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c30855f1980b63b4cfe33b6d7d9719c1b6f7103

commit 8c30855f1980b63b4cfe33b6d7d9719c1b6f7103
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-07-18 05:15:37 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-07-18 05:15:37 +0000

    mail/xmail: Make buildable again under 14-CURRENT

    Circumvent -Wincompatible-function-pointer-types to make build
    under 14-CURRENT again and revert 093a84fae0a8 (deprecation).

    Pending maintainer approval the next step will be assume
    maintainership.

    PR:     272558

 mail/xmail/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 6 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 05:24:33 UTC
Created attachment 243455 [details]
Assume maintainership.

sjroz@verizon.net,

Please approve my assumption of this port's maintainership.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-07-18 13:00:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5cf3315223b2e126820cdbbcaf6a7df290b48e50

commit 5cf3315223b2e126820cdbbcaf6a7df290b48e50
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2023-07-18 12:54:38 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2023-07-18 12:57:51 +0000

    mail/xmail: Assume maintainership

    PR:             272558
    Approved by:    sjroz@verizon.net (maintainer)

 mail/xmail/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 13:03:36 UTC
Thank you for the care and feeding of this port up to now.
Comment 9 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 13:11:00 UTC
Never mind the maintainer feedback cancellation. I had "enabled" for the patch and for the PR. This was redundant on my part. Approval of the patch was sufficient.
Comment 10 Koichiro Iwao freebsd_committer freebsd_triage 2023-07-18 14:42:44 UTC
Cy, thanks for the catch!
Comment 11 Cy Schubert freebsd_committer freebsd_triage 2023-07-18 15:01:08 UTC
No worries.

There were a couple of other things I fixed: pty handling was broken since FreeBSD started using openpty() a while ago. And, xmail doesn't like aslr. It segfaults. We can work around that too.

There is another issue that I will poke at when I have the time.