Bug 272577 - archivers/libarchive: Update to 3.7.1
Summary: archivers/libarchive: Update to 3.7.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Greg Lewis
URL: https://github.com/libarchive/libarch...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-18 20:04 UTC by Daniel Engberg
Modified: 2023-08-18 17:37 UTC (History)
1 user (show)

See Also:
glewis: maintainer-feedback+


Attachments
Patch for libarchive (7.09 KB, patch)
2023-07-18 20:04 UTC, Daniel Engberg
no flags Details | Diff
Patch for libarchive (7.06 KB, patch)
2023-07-31 17:43 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-07-18 20:04:06 UTC
Created attachment 243466 [details]
Patch for libarchive

Prelim patch

* Move plist to pkg-plist
* Rework Makefile to follow Porters Handbook more closely and tree overall

test_read_disk_directory_traversals fails on 13.2-RELEASE (amd64), I tried adding "USE_LOCALE=en_US.UTF-8" but it didn't seem to help as mentioned in a report on GitHub. This is also true for 3.6.2
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-07-23 08:33:16 UTC
Martin, can you have a look at the unit test failure? Not sure what's causing it
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-07-31 17:43:05 UTC
Created attachment 243748 [details]
Patch for libarchive
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-07-31 17:48:04 UTC
Compile and runtime tested on FreeBSD 13.2-RELEASE (aarch64) (make, make check-plist, make test)
Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test)

Poudriere testport OK 12.4-RELEASE (amd64)
Poudriere testport OK 13.2-RELEASE (amd64)

Tested with following consumers in 13.2-RELEASE (amd64) using Poudriere:
net/samba413
net/samba416
science/v_sim
archivers/ark
archivers/file-roller
archivers/gnome-autoar
archivers/pixz
archivers/rpm4
archivers/rubygem-libarchive
archivers/unmakeself
astro/opencpn
audio/ardour
audio/cardinal
audio/guitarix-lv2
audio/hydrogen
cad/horizon-eda
deskutils/pinot
devel/appstream-glib
devel/cmake-gui
devel/gvfs
devel/libtifiles2
devel/zeal
emulators/cemu
emulators/dgen-sdl
emulators/nemu
emulators/nestopia
games/lordsawar
games/meandmyshadow
games/melonds
graphics/akira
graphics/atril
graphics/atril-lite
graphics/evince
graphics/filmulator
graphics/geeqie
graphics/glaxnimate
graphics/libgxps
graphics/minder
graphics/tesseract
graphics/zathura-cb
irc/epic5
lang/swi-pl
mail/claws-mail-archive
mail/evolution
multimedia/lms
multimedia/mlt7-glaxnimate
multimedia/mpv
multimedia/qmmp-qt5
multimedia/qmmp-qt6
multimedia/totem-pl-parser
net/grilo-plugins
net-mgmt/seafile-client
net-mgmt/seafile-server
science/avogadro2
science/avogadrolibs
sysutils/apache-mesos (fails (unrelated), configure: error: Cannot find the ELFIO headers) 
sysutils/archivemount
sysutils/ftwin
sysutils/fwup
sysutils/osinfo-db-tools
sysutils/pacman
sysutils/rdup
textproc/libextractor (fails, marked broken)
textproc/libgepub
www/epiphany
www/midori
x11/gnome-pie
Comment 4 Greg Lewis freebsd_committer freebsd_triage 2023-08-17 05:59:24 UTC
Thanks, this looks good to me
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-08-18 17:35:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bdb933b4223ee1ec70a278e2a51b89fb3d3e918d

commit bdb933b4223ee1ec70a278e2a51b89fb3d3e918d
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-18 17:01:06 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-08-18 17:34:14 +0000

    archivers/libarchive: Update to 3.7.1

    * Move plist from Makefile to pkg-list

    Changelog: https://github.com/libarchive/libarchive/releases/tag/v3.7.1

    PR:             272577
    Reviewed by:    glewis (maintainer)
    Sponsored by:   Blinkinblox

 archivers/libarchive/Makefile                      | 80 ++++------------------
 archivers/libarchive/distinfo                      |  8 +--
 ...libarchive-archive_openssl_evp_private.h (gone) | 12 ----
 archivers/libarchive/pkg-plist (new)               | 55 +++++++++++++++
 4 files changed, 70 insertions(+), 85 deletions(-)