Bug 272628 - graphics/darktable: remove empty PORTREVISION
Summary: graphics/darktable: remove empty PORTREVISION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-20 21:13 UTC by Philipp Ost
Modified: 2023-07-21 06:39 UTC (History)
0 users

See Also:
dumbbell: maintainer-feedback+

Attachments
graphics/darktable: remove empty PORTREVISION (388 bytes, patch)
2023-07-20 21:13 UTC, Philipp Ost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2023-07-20 21:13:52 UTC 
Created attachment 243511 [details]
graphics/darktable: remove empty PORTREVISION

graphics/darktable fails to build with:
/!\ darktable-4.4.1: Makefile errors /!\

PORTREVISION needs to be an integer >= 0

*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/darktable
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/darktable

The reason is the empty PORTREVISION statement introduced in commit 	229b2f86274a443876fdb8a9497109a18a459d66. The attached patch fixes this.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-07-21 06:38:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e6f8f224bd66d86dfff77c92160d024e52a5747c

commit e6f8f224bd66d86dfff77c92160d024e52a5747c
Author:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
AuthorDate: 2023-07-21 06:33:04 +0000
Commit:     Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
CommitDate: 2023-07-21 06:33:04 +0000

    graphics/darktable: Remove empty PORTREVISION

    The port failed to build with the following error:

        graphics/darktable fails to build with:
        /!\ darktable-4.4.1: Makefile errors /!\

        PORTREVISION needs to be an integer >= 0

    PR:             272628
    Reported by:    Philipp Ost <bsd@philippost.de>
    Submitted by:   Philipp Ost <bsd@philippost.de>

 graphics/darktable/Makefile | 1 -
 1 file changed, 1 deletion(-)
Comment 2 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2023-07-21 06:39:03 UTC 
Thank you! Patch committed :)