Bug 272662 - multimedia/onevpl: needs ISO C++ 2014
Summary: multimedia/onevpl: needs ISO C++ 2014
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-22 11:26 UTC by Trond Endrestøl
Modified: 2023-07-22 13:11 UTC (History)
1 user (show)

See Also:


Attachments
Proper Git formatted patch for multimedia/onevpl/Makefile selecting ISO C++ 2014 (495 bytes, patch)
2023-07-22 11:26 UTC, Trond Endrestøl
no flags Details | Diff
Proper Git formatted patch for multimedia/onevpl/Makefile selecting ISO C++ 2014 (513 bytes, patch)
2023-07-22 12:22 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2023-07-22 11:26:47 UTC
Created attachment 243547 [details]
Proper Git formatted patch for multimedia/onevpl/Makefile selecting ISO C++ 2014
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-22 12:12:52 UTC
Hello,

Confirmed that port fails with clang16.
I will take a look at error log and try to get the reason why it's failing to adjust clang or in last case use USE_CXXSTD=c++14.

I'm not familiar with this software and there is available a new version, so if you use it and know how it works we could give a try update it.

Thanks
Comment 2 Trond Endrestøl 2023-07-22 12:22:04 UTC
Created attachment 243548 [details]
Proper Git formatted patch for multimedia/onevpl/Makefile selecting ISO C++ 2014
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-22 12:29:04 UTC
Same build failure with c++14 std on CURRENT 1400093:

Error log:
---
In file included from /wrkdirs/usr/ports/multimedia/onevpl/work/oneVPL-2022.1.5/tools/legacy/sample_common/src/base_allocator.cpp:7:
/wrkdirs/usr/ports/multimedia/onevpl/work/oneVPL-2022.1.5/tools/legacy/sample_common/include/base_allocator.h:146:27: error: no template named 'binary_function' in namespace 'std'; did you mean '__binary_function
'?
            : public std::binary_function<mfxFrameAllocResponse, mfxFrameAllocResponse, bool> {
                     ~~~~~^~~~~~~~~~~~~~~
                          __binary_function
/usr/include/c++/v1/__functional/binary_function.h:49:1: note: '__binary_function' declared here
using __binary_function = __binary_function_keep_layout_base<_Arg1, _Arg2, _Result>;
^
/wrkdirs/usr/ports/multimedia/onevpl/work/oneVPL-2022.1.5/tools/legacy/sample_common/src/base_allocator.cpp:167:63: error: no member named 'bind1st' in namespace 'std'
                                                         std::bind1st(IsSame(), *response));
                                                         ~~~~~^
/wrkdirs/usr/ports/multimedia/onevpl/work/oneVPL-2022.1.5/tools/legacy/sample_common/src/base_allocator.cpp:179:67: error: no member named 'bind1st' in namespace 'std'
        std::find_if(m_responses.begin(), m_responses.end(), std::bind1st(IsSame(), *response));
                                                             ~~~~~^
3 errors generated.
---
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-22 12:30:19 UTC
(In reply to Trond.Endrestol from comment #2)

Using compiler:c++14-lang will choose a c++14 capable compiler and it will be obsoleted soon.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-22 13:04:12 UTC
(In reply to Nuno Teixeira from comment #3)

I was working with wrong git tree so thats why I was having same results.
Rebuilding and testing...
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-07-22 13:09:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=290685cd059422d4afa8712c7beb0b4b3d7fcb73

commit 290685cd059422d4afa8712c7beb0b4b3d7fcb73
Author:     Trond Endrestol <Trond.Endrestol@ximalas.info>
AuthorDate: 2023-07-22 13:06:47 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-07-22 13:08:43 +0000

    multimedia/onevpl: Fix build with llvm16

    - Pet portclippy and portfmt

    PR:             272662

 multimedia/onevpl/Makefile | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-07-22 13:11:36 UTC
Committed, thanks!