Bug 272679 - audio/zita-jclient: Remove NATIVE option and disable unsafe optimization
Summary: audio/zita-jclient: Remove NATIVE option and disable unsafe optimization
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-23 13:25 UTC by Daniel Engberg
Modified: 2023-08-07 06:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Patch for zita-jclient (2.00 KB, patch)
2023-07-23 13:25 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2023-07-23 13:25:32 UTC 
Created attachment 243567 [details]
Patch for zita-jclient

Drop NATIVE option, rely on CPUTYPE instead
Remove --ffast-math, this is unsafe and known to cause issues
Convert PORTVERSION to DISTVERSION for consistency

Compile tested on FreeBSD 13.2-RELEASE (amd64)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-07 06:13:57 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-07 06:14:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b696e1efe9b45a686a920391fbeac5f7e50e0a14

commit b696e1efe9b45a686a920391fbeac5f7e50e0a14
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-07 06:13:12 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-07 06:14:01 +0000

    audio/zita-jclient: Remove NATIVE option and disable unsafe optimization

    PR:             272679

 audio/zita-jclient/Makefile             | 13 ++++---------
 audio/zita-jclient/files/patch-Makefile |  7 +++----
 2 files changed, 7 insertions(+), 13 deletions(-)