Bug 272753 - devel/mongo-c-driver: fix build with openssl 3
Summary: devel/mongo-c-driver: fix build with openssl 3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 12:24 UTC by Hiroo Ono
Modified: 2023-07-29 16:57 UTC (History)
2 users (show)

See Also:
fernape: maintainer-feedback+

Attachments
small fixes. (1.06 KB, patch)
2023-07-27 12:24 UTC, Hiroo Ono 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2023-07-27 12:24:53 UTC 
Created attachment 243643 [details]
small fixes.

Two fixes to the port Makefile.
* In the previous bug, I forgot to remove one commented out line. Sorry.
* A trailing double quote following 0x30000000L makes the build fail
  with DEFAULT_VERSIONS+=ssl=openssl30 (and maybe openssl31). Remove it.
  see: https://lists.freebsd.org/archives/freebsd-ports/2023-July/004180.html
   and https://lists.freebsd.org/archives/freebsd-ports/2023-July/004191.html

Other than devel/mongo-c-driver, these are the ports Makefile which has trailing double quote:
./mail/datovka/Makefile:CXXFLAGS+=      -DOPENSSL_API_COMPAT=0x30000000L"
./mail/archiveopteryx/Makefile:CXXFLAGS+=       -DOPENSSL_API_COMPAT=0x30000000L"
./news/nzbget/Makefile:CXXFLAGS+=       -DOPENSSL_API_COMPAT=0x30000000L"
./devel/ucommon/Makefile:CXXFLAGS+=      -DOPENSSL_API_COMPAT=0x30000000L"
./devel/thrift-c_glib/Makefile:CXXFLAGS+=       -DOPENSSL_API_COMPAT=0x30000000L"
./security/git-crypt/Makefile:CXXFLAGS+=        -DOPENSSL_API_COMPAT=0x30000000L"
./databases/xrootd/Makefile:CXXFLAGS+=  -DOPENSSL_API_COMPAT=0x30000000L"
./lang/php80/Makefile:CXXFLAGS+=        -DOPENSSL_API_COMPAT=0x30000000L"
./net/asterisk18/Makefile:CFLAGS+=      -DOPENSSL_API_COMPAT=0x30000000L"
./sysutils/istatserver/Makefile:CXXFLAGS+=      -DOPENSSL_API_COMPAT=0x30000000L"
./www/lagrange/Makefile:CXXFLAGS+=      -DOPENSSL_API_COMPAT=0x30000000L"
Comment 1 Krzysztof 2023-07-27 12:54:23 UTC 
Comment on attachment 243643 [details]
small fixes.

OK
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-28 07:08:57 UTC 
(In reply to Hiroo Ono from comment #0)
The patch does not apply since the change to the OPENSSL part was already made by bofh@. Then, only the removal of the commented out line is pending.

I will just remove that line and commit that.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-07-29 16:56:29 UTC 
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-07-29 16:57:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1238b1e82d53150d2d8f1bf2edfbbcef95b9cca5

commit 1238b1e82d53150d2d8f1bf2edfbbcef95b9cca5
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2023-07-28 07:09:22 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-07-29 16:55:56 +0000

    devel/mongo-c-driver: Remove commented out line

    PR:             272753
    Reported by:    hiroo.ono+freebsd@gmail.com
    Approved by:    ports@bsdserwis.com (maintainer)

 devel/mongo-c-driver/Makefile | 2 --
 1 file changed, 2 deletions(-)