Bug 272794 - finance/odoo: Breakage caused by Werkzeug 2.3.x
Summary: finance/odoo: Breakage caused by Werkzeug 2.3.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-29 12:16 UTC by yzrh
Modified: 2023-08-05 05:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
Fix FutureResponse (329 bytes, patch)
2023-07-29 12:16 UTC, yzrh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yzrh 2023-07-29 12:16:16 UTC
Created attachment 243686 [details]
Fix FutureResponse

Werkzeug 2.3.x has been in quarterly for quite some time now.
Installing odoo from quarterly works, but when visited with a web
browser, 500 is always returned.

ERROR odoo odoo.http: Exception during request handling.
Traceback (most recent call last):
  File ".../odoo/http.py", line 1993, in __call__
    response = request._serve_db()
  File ".../odoo/http.py", line 1578, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File ".../odoo/service/model.py", line 134, in retrying
    result = func()
  File ".../odoo/http.py", line 1608, in _serve_ir_http
    ir_http._post_dispatch(response)
  File ".../odoo/addons/base/models/ir_http.py", line 147, in _post_dispatch
    request.dispatcher.post_dispatch(response)
  File ".../odoo/http.py", line 1676, in post_dispatch
    self.request._save_session()
  File ".../odoo/http.py", line 1506, in _save_session
    self.future_response.set_cookie('session_id', sess.sid, max_age=SESSION_LIFETIME, httponly=True)
  File ".../odoo/http.py", line 1124, in set_cookie
    werkzeug.Response.set_cookie(self, key, value=value, max_age=max_age, expires=expires, path=path, domain=domain, secure=secure, httponly=httponly, samesite=samesite)
  File ".../werkzeug/sansio/response.py", line 258, in set_cookie
    charset = self._charset if self._charset != "utf-8" else None
AttributeError: 'FutureResponse' object has no attribute '_charset'

The fix is trivial.
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-08-05 05:57:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=13e5bae1115a528f57da04de6fa018cbf4d512c5

commit 13e5bae1115a528f57da04de6fa018cbf4d512c5
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2023-08-05 05:52:08 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2023-08-05 05:52:08 +0000

    finance/odoo: update to 16.0.20230804

    - Add commit date to PORTREVISION
    - Add missing dependency
    - Fix issues with recent version of Werkzeug 2.3.x
    - Fix typo into pkg-message
    - Other minor modifications

    PR:             272379 272794
    Reported by:    Jens Grassel <freebsd-ports  at_ jan0sch.de>, yzrh _at_ noema.org, fgarcia _at koali.es

 finance/odoo/Makefile             |   15 +-
 finance/odoo/distinfo             |    6 +-
 finance/odoo/files/odoo.conf      |    2 +-
 finance/odoo/files/pkg-message.in |    2 +-
 finance/odoo/pkg-plist            | 4940 +++++++++++++++++++++++++++++++++++--
 5 files changed, 4745 insertions(+), 220 deletions(-)
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2023-08-05 05:57:48 UTC
Committed thanks!