Bug 272817 - devel/py-qt5-qscintilla2: pkg-plist breaks build of graphics/qgis
Summary: devel/py-qt5-qscintilla2: pkg-plist breaks build of graphics/qgis
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-30 14:07 UTC by Rainer Hurling
Modified: 2023-08-01 17:54 UTC (History)
3 users (show)

See Also:


Attachments
patch to update pkg-plist for v2.14.1 (1.65 KB, patch)
2023-07-30 14:07 UTC, Rainer Hurling
no flags Details | Diff
Patch to bump portrevision (397 bytes, patch)
2023-08-01 17:17 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer freebsd_triage 2023-07-30 14:07:06 UTC
Created attachment 243706 [details]
patch to update pkg-plist for v2.14.1

After updating Qscintilla (and other Qt/KDE-related ports) a few days ago, the graphics/qgis port no longer builds:

[...]
sip-build: /usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 63: column 10: 'qscilexerasm.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 77: column 10: 'qscilexerhex.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 80: column 10: 'qscilexerintelhex.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 87: column 10: 'qscilexermasm.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 89: column 10: 'qscilexernasm.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 101: column 10: 'qscilexersrec.sip' could not be found
/usr/local/lib/python3.9/site-packages/PyQt5/bindings/Qsci/qscimodcommon.sip: line 103: column 10: 'qscilexertekhex.sip' could not be found
gmake[4]: *** [python/CMakeFiles/python_module_qgis__gui.dir/build.make:1325: python/gui/build/_gui/sip_guipart0.cpp] Error 1
gmake[4]: Leaving directory '/usr/ports/graphics/qgis/work/.build'
gmake[3]: *** [CMakeFiles/Makefile2:10492: python/CMakeFiles/python_module_qgis__gui.dir/all] Error 2


The files qscimodcommon.sip complains about are actually not there. The build of devel/py-qt5-qscintilla2 does install them correctly in the staging area. However, since there are no entries for these files in the pkg-plist, 'make install' does not install them either.

Package builders also already fail because of this bug, for example https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p04fdfe963096_sc620788150/logs/qgis-3.32.1_1.log.

The attached patch corrects the pkg-plist. py-qt5-qscintilla2 builds, installs and works fine for me now, also graphics/qgis is built again ...
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2023-07-31 19:09:08 UTC
My bad. Assign to myself.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-07-31 20:16:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5a423f9e863fa676f7c27c985f5713f50726924c

commit 5a423f9e863fa676f7c27c985f5713f50726924c
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-07-31 20:04:14 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-07-31 20:13:46 +0000

    devel/py-qt5-qscintilla2: Fix pkg-plist

    pkg-plist wasn't updated with 5bcefb9d57ea causing dependent ports
    to break.

    PR:             272817
    Pointy hat:     jhale

 devel/py-qt5-qscintilla2/pkg-plist | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2023-07-31 20:24:24 UTC
Thanks, Rainer! I’m really sorry for for the fallout. I neglected to check the Qt5 side of things when I was updating the Qt6 ports, but I will be more diligent in the future.
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2023-08-01 03:46:18 UTC
No problem and many thanks for the commit.
Comment 5 Rainer Hurling freebsd_committer freebsd_triage 2023-08-01 17:17:33 UTC
Created attachment 243775 [details]
Patch to bump portrevision

Sorry, the previous patch was incomplete :(

Of course the PORTREVISION must be increased so that the port is rebuilt by the package builders.
Comment 6 Rainer Hurling freebsd_committer freebsd_triage 2023-08-01 17:19:21 UTC
The second attached patch must also be committed.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-08-01 17:53:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e3870422c83310c98c03bf15312bf046a0fe17b5

commit e3870422c83310c98c03bf15312bf046a0fe17b5
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2023-08-01 17:48:44 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-08-01 17:52:34 +0000

    devel/py-qt5-qscintilla2: Bump PORTREVSION after 5a423f9e863f

    PR:             272817

 devel/py-qt5-qscintilla2/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 8 Jason E. Hale freebsd_committer freebsd_triage 2023-08-01 17:54:31 UTC
Committed, thanks again!