Bug 272936 - devel/rapidjson: unbreak tests
Summary: devel/rapidjson: unbreak tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-04 12:30 UTC by Jan Beich
Modified: 2023-08-04 17:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
v1 (apply via "git am") (3.75 KB, patch)
2023-08-04 12:30 UTC, Jan Beich 		no flags Details | Diff
v1.1 (apply via "git am") (3.71 KB, patch)
2023-08-04 12:57 UTC, Jan Beich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2023-08-04 12:30:52 UTC 
Created attachment 243836 [details]
v1 (apply via "git am")
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-08-04 12:57:55 UTC 
Created attachment 243838 [details]
v1.1 (apply via "git am")

Switch to CMAKE_TESTING_ARGS and use lazy evaluation as ${ARCH} is undefined before .include
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-04 15:57:33 UTC 
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-08-04 15:58:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96c827a89186661d75b54acd1f11c9d962a96a1f

commit 96c827a89186661d75b54acd1f11c9d962a96a1f
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2023-08-04 15:56:48 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-08-04 15:57:29 +0000

    devel/rapidjson: unbreak tests

    PR:             272936

 devel/rapidjson/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Comment 4 Jan Beich freebsd_committer freebsd_triage 2023-08-04 16:31:38 UTC 
Did you intentionally discard commit messages in the patch? It was supposed to be a series of 3 commits, each fixing a different issue related to tests.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2023-08-04 17:27:43 UTC 
(In reply to Jan Beich from comment #4)

Hi Jan,

It wasn't intentional. Multitasking caused me to to not pay sufficient attention.
I apologize for overlooking this. :-(


Yuri