Bug 272985 - french/verbiste: update to 0.1.48
Summary: french/verbiste: update to 0.1.48
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Christian Weisgerber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-06 19:58 UTC by Christian Weisgerber
Modified: 2023-08-09 10:59 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (dereckson)

Attachments
verbiste.patch (5.84 KB, text/plain)
2023-08-06 19:58 UTC, Christian Weisgerber 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Weisgerber freebsd_committer freebsd_triage 2023-08-06 19:58:38 UTC 
Created attachment 243909 [details]
verbiste.patch

Update french/verbiste to 0.1.48.

Clean up the port after the forced removal of the GNOME option in
commit c399c4d12f6462f1d535e9a3143fe0e679a63eb8.

Ok to commit?
Comment 1 dereckson 2023-08-06 20:53:06 UTC 
Makefile changes look good to me, do you have a poudriere log?
Comment 2 Christian Weisgerber freebsd_committer freebsd_triage 2023-08-06 21:10:03 UTC 
(In reply to dereckson from comment #1)
No, I don't have a poudriere setup.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-08-06 22:11:41 UTC 
What other testing have you done?
Changes look OK.  Maintainer has approved.
@naddy don't you have a ports bit anyway?
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-07 06:28:37 UTC 
^Triage: tags in the title are deprecated.
^Triage: reporter is committer, assign accordingly.
Comment 5 Christian Weisgerber freebsd_committer freebsd_triage 2023-08-07 07:36:04 UTC 
(In reply to Robert Clausecker from comment #3)
I built the port and package, with -DDEVELOPER, with and without option GTK2, verified that the command line tools and the gtk program work, and successfully ran the regression tests.

I'm now waiting for the maintainer's approval.

(I had forgotten to assign the PR to myself.)
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-07 07:51:00 UTC 
(In reply to Christian Weisgerber from comment #5)
Those are good steps to test the port, but will not catch a number of common problems. For instance, since the port is not built in a clean environment, it would be difficult to detect new dependencies that might happen to be installed in the host system for instance.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-08-07 08:37:44 UTC 
Maintainer has already indicated approval in comment #1 it looks like.
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-08-09 10:58:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2a2f2cb31d3980fba2de1454139633e271de7826

commit 2a2f2cb31d3980fba2de1454139633e271de7826
Author:     Christian Weisgerber <naddy@FreeBSD.org>
AuthorDate: 2023-08-06 19:50:41 +0000
Commit:     Christian Weisgerber <naddy@FreeBSD.org>
CommitDate: 2023-08-09 10:55:49 +0000

    french/verbiste: update to 0.1.48

    Maintenance update, no significant changes.

    Clean up the port after the forced removal of the GNOME option in
    commit c399c4d12f6462f1d535e9a3143fe0e679a63eb8.

    PR:             272985
    Approved by:    maintainer

 french/verbiste/Makefile                | 22 ++++++----------------
 french/verbiste/distinfo                |  6 +++---
 french/verbiste/files/patch-Makefile.in | 17 ++++-------------
 french/verbiste/pkg-plist               | 29 +++++++++++++++--------------
 4 files changed, 28 insertions(+), 46 deletions(-)