Created attachment 243998 [details] starfetch-0.0.4.patch Description: * Use a hardcoded string instead of ${PORTNAME} * Remove AppleDouble encoded Macintosh files (included in this release, cause `Abort (core dumped)`) ChangeLog: https://github.com/Haruno19/starfetch/releases/tag/0.0.4 * Overall better and cleaner code * Compatibility for Windows systems * Full Qt5/6 GUI version for starfetch * Lets the user choose between black, white, cyan, magenta, yellow, red and blue to color part of the output QA: * portlint: OK (looks fine.) * testport: (poudriere: 13.2-RELEASE, amd64): - Warning: Possible REINPLACE_CMD issues: - - REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp
Instead of ${FIND} ... -exec ${RM} {} \;, you can filter files during COPYTREE_SHARE. I'll amend the patch to do this for you. There is no need to strip the binary again. ${INSTALL_PROGRAM} already strips programs it installs for you. I'll also go ahead and merge post-install into do-install. There does not seem to be a reason to have both. Lastly, your compiler invocation should obey all of CPPFLAGS, CXXFLAGS, and LDFLAGS. I'll go ahead and edit the missing ones in.
(In reply to Robert Clausecker from comment #1) Thanks Robert, I'll keep that in mind!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d0f288a5599116fc41163034ebd62a3d8c8e6277 commit d0f288a5599116fc41163034ebd62a3d8c8e6277 Author: Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> AuthorDate: 2023-08-10 08:46:40 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-08-13 09:32:55 +0000 astro/starfetch: Update to 0.0.4 * Remove trailing slash in WWW * Use a hardcoded string instead of ${PORTNAME} * Remove AppleDouble encoded Macintosh files (included in this release, cause `Abort (core dumped)`) ChangeLog: https://github.com/Haruno19/starfetch/releases/tag/0.0.4 * Overall better and cleaner code * Compatibility for Windows systems * Full Qt5/6 GUI version for starfetch * Lets the user choose between black, white, cyan, magenta, yellow, red and blue to color part of the output PR: 273039 astro/starfetch/Makefile | 18 +++++++----------- astro/starfetch/distinfo | 6 +++--- 2 files changed, 10 insertions(+), 14 deletions(-)
Thank you for your contribution.