Created attachment 244048 [details] Patch for povray38 * Drop NATIVE option, utilize CPUTYPE instead which is support using the framework via /etc/make.conf * Don't try to override optimization set by framework by defualt * Utilize framework helpers more and do some slight rearrangement for better readability and consistentcy with Porters Handbook
I'm fine with the changes, except dropping OPTIMIZED_CFLAGS. I'd like to keep that option around. You mention using CPUTYPE, but it's nowhere to be found in your patch. Am I missing something?
Hi, We're working on removing -march=native treewide because it's non-portable (doesn't work on anything non x86), known to cause issues including misdetection and can possibly override framework settings. CPUTYPE is a part of the framework and is documented here: https://cgit.freebsd.org/src/tree/share/examples/etc/make.conf#n25 Best regards, Daniel
Friendly ping
(In reply to Daniel Engberg from comment #3) I haven't forgotten this PR. As I'm quite busy currently, I didn't yet reply with a constructive answer. Please allow me a couple of days; I'll get back to you as soon as I can.
Created attachment 244288 [details] graphics/povray38/Makefile: drop NATIVE option, carry over rest of changes Drop NATIVE, but keep OPTIMIZED_CFLAGS around. The rest of the changes are carried over.
Comment on attachment 244048 [details] Patch for povray38 After some additional test, it became clear that OPTIMIZED_CFLAGS without march=native is not giving the speed gains that make it worthwhile keeping around. Please commit your original patch. I'm very sorry for the mess and the delay.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9549a20a0be5687d170dc419de5e5c8f1026af8c commit 9549a20a0be5687d170dc419de5e5c8f1026af8c Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-08-26 17:03:12 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-08-26 17:03:18 +0000 graphics/povray38: Remove NATIVE option and do some cleanups - Drop NATIVE option, utilize CPUTYPE instead which is supported using the framework via /etc/make.conf - Don't override optimization set by framework - Utilize framework helpers more and do some slight rearrangement for better readability and consistency with Porters Handbook PR: 273098 Reviewed by: Philipp Ost <bsd@philippost.de> (maintainer) Sponsored by: Blinkinblox graphics/povray38/Makefile | 32 +++++++++++++------------------- 1 file changed, 13 insertions(+), 19 deletions(-)
Committed, thanks!