Bug 273130 - graphics/xfig: update to 3.2.8b
Summary: graphics/xfig: update to 3.2.8b
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://sourceforge.net/p/mcj/xfig/ci...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-14 08:33 UTC by mjl
Modified: 2023-08-17 12:34 UTC (History)
1 user (show)

See Also:


Attachments
update graphics/xfig to 3.2.8b (1.57 KB, patch)
2023-08-14 08:33 UTC, mjl
mjl: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mjl 2023-08-14 08:33:18 UTC
Created attachment 244089 [details]
update graphics/xfig to 3.2.8b

ChangeLog at:

https://sourceforge.net/p/mcj/xfig/ci/master/tree/CHANGES

In this version:

Patchlevel 8b (Aug 2021)

BUGS FIXED:
	o Adding points to splines works if boxes are present in the figure.
	o Stay in the working directory when browsing picture files.

My patch attached should also fix the build on freebsd 14 / i386.  I have submitted the patch upstream as well.

https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pd1b7aad5f3cc_s93626d5437/logs/xfig-3.2.8a_1.log
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-14 10:57:12 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

^Triage: please mark attachments as "patch" if it applies.

Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-15 11:33:49 UTC
How is it that the update is to patch 8b from August 2021 and not patch 9 from November 2022?
Comment 3 mjl 2023-08-15 19:35:25 UTC
The latest released version is 3.2.8b.  See the green button:

https://sourceforge.net/projects/mcj/files/

And here at the homepage:

https://mcj.sourceforge.net/
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-16 06:06:54 UTC
(In reply to mjl from comment #3)
I'm confused. In the ChangeLog that is linked to the PR, after 8b there is a patch level 9 dated November 2022
Comment 5 mjl 2023-08-16 08:29:15 UTC
If you can find a release for 3.2.9, then I will resubmit the patch.  I have pointed out that two xfig websites say current release is 3.2.8b.  Other platforms:

Macports: https://ports.macports.org/port/xfig/ 3.2.8b
Brew: https://formulae.brew.sh/formula/xfig#default 3.2.8b
OpenBSD: http://cvsweb.openbsd.org/ports/graphics/xfig/Makefile 3.2.8b
NetBSD: http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/graphics/xfig/Makefile 3.2.8b

Beyond this, the patch I included fixes the build on FreeBSD 14 i386.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-17 12:02:26 UTC
(In reply to mjl from comment #5)
Clarified: https://sourceforge.net/p/mcj/discussion/general/thread/f253d577dd/?limit=25#a7ef
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-17 12:33:59 UTC
Committed,

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-08-17 12:34:33 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a77d20836a9c6afed1dfaa4cee6906bc32d9fbb1

commit a77d20836a9c6afed1dfaa4cee6906bc32d9fbb1
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2023-08-14 11:01:35 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-17 12:33:21 +0000

    graphics/xfig: update to 3.2.8b

    ChangeLog: https://sourceforge.net/p/mcj/xfig/ci/master/tree/CHANGES

    This update also fixes the build in 14.

    BUGS FIXED:
     * Adding points to splines works if boxes are present in the figure.
     * Stay in the working directory when browsing picture files.

    PR:             273130
    Reported by:    mjl@luckie.org.nz (maintainer)

 graphics/xfig/Makefile                               |  3 +--
 graphics/xfig/distinfo                               |  6 +++---
 graphics/xfig/files/patch-src_u__ghostscript.c (new) | 17 +++++++++++++++++
 3 files changed, 21 insertions(+), 5 deletions(-)