Bug 273189 - net/dhcpcd: pkg-message is misleading or wrong or not useful
Summary: net/dhcpcd: pkg-message is misleading or wrong or not useful
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dries Michiels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-17 21:54 UTC by jeff.bachtel
Modified: 2024-04-10 11:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (driesm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jeff.bachtel 2023-08-17 21:54:42 UTC
The current pkg-message for net/dhcpcd is:

"""
The default FreeBSD kernel does not allow userland to provide IPv6
Prefix Routes when the kernel is handling Router Advertisements.
The default dhcpcd configuration will disable the kernel from handling
Router Advertisements.

See http://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194485 for a patch.
"""

However, there are no visible options in `dhcpcd.conf` to indicate the kernel is disabled from handling Router Advertisements. There are no options in dhcpcd documentation for such an effect.

In addition, the patch linked to has been merged in `13.2` and higher, so if there IS an option of dhcpcd that is disabling kernel route advertisements, it should be removed (to be clear, I don't think such a thing exists).
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2023-08-29 08:57:51 UTC
The comment can be removed from the package when 12-STABLE is EOL expected end of 2023.
Comment 2 jeff.bachtel 2023-08-29 14:45:49 UTC
Ok, but as far as I can tell, there is nothing in the dhcpcd configuration that disables the kernel from handling RAs. So even in 12, the message itself is misleading.

If I'm wrong and you know there's definitely a configuration directive that is disabling kernel RA broadcasts, could the message be updated to reflect what the directive is?

If the kernel's RA broadcasts are disabled inherently as part of dhcpcd running (that is, it is not tied to configuration), could that be indicated instead?
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-04-10 11:28:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a21e34c79e2637f4426e142e7645bf9dd7f942a1

commit a21e34c79e2637f4426e142e7645bf9dd7f942a1
Author:     Dries Michiels <driesm@FreeBSD.org>
AuthorDate: 2024-04-10 11:25:36 +0000
Commit:     Dries Michiels <driesm@FreeBSD.org>
CommitDate: 2024-04-10 11:25:36 +0000

    net/dhcpcd: remove pkg-message

    pkg-message has become obsolete when PR 194485 was committed.

    PR:     273189

 net/dhcpcd/pkg-message (gone) | 12 ------------
 1 file changed, 12 deletions(-)