Created attachment 244197 [details] Patch for libxml2 This also includes necessary changes to textproc/py-libxml2 Compile and runtime tested on FreeBSD 13.2-RELEASE (amd64) (make, make check-plist, make test) Poudriere testport OK 12.4-RELEASE (amd64) Poudriere testport OK 13.2-RELEASE (amd64) Tested with following consumers in 12.4-RELEASE (amd64) using Poudriere: devel/appstream-glib editors/ghex games/aisleriot games/four-in-a-row games/gnome-2048 games/gnome-chess games/gnome-klotski games/gnome-mahjongg games/gnome-nibbles games/gnome-robots games/gnome-taquin games/gnome-tetravex games/hitori games/iagno games/lightsoff games/quadrapassel games/tali misc/gnome-getting-started-docs misc/gnome-user-docs multimedia/cheese net/gnome-nettool security/sssd security/sssd-devel sysutils/darling-dmg sysutils/mstflint-lite sysutils/nix textproc/meld textproc/xmlto x11/xcb-proto x11-wm/metacity accessibility/caribou archivers/file-roller archivers/xar archivers/xarchiver astro/foxtrotgps astro/gpscorrelate audio/abgate-lv2 audio/aqualung audio/ardour audio/ario audio/denemo audio/easytag audio/eq10q-lv2 audio/ezstream audio/ganv audio/gnaural audio/gsequencer audio/gstreamer1-plugins-a52dec audio/gstreamer1-plugins-amrnb audio/gstreamer1-plugins-amrwbdec audio/gstreamer1-plugins-bs2b audio/gstreamer1-plugins-cdparanoia audio/gstreamer1-plugins-chromaprint audio/gstreamer1-plugins-faac audio/gstreamer1-plugins-faad audio/gstreamer1-plugins-flac audio/gstreamer1-plugins-flite audio/gstreamer1-plugins-gme audio/gstreamer1-plugins-gsm audio/gstreamer1-plugins-jack audio/gstreamer1-plugins-ladspa audio/gstreamer1-plugins-lame audio/gstreamer1-plugins-lv2 audio/gstreamer1-plugins-modplug audio/gstreamer1-plugins-mpg123 audio/gstreamer1-plugins-musepack audio/gstreamer1-plugins-ogg audio/gstreamer1-plugins-openmpt audio/gstreamer1-plugins-opus audio/gstreamer1-plugins-pulse audio/gstreamer1-plugins-shout2 audio/gstreamer1-plugins-sidplay audio/gstreamer1-plugins-sndfile audio/gstreamer1-plugins-soundtouch audio/gstreamer1-plugins-speex audio/gstreamer1-plugins-taglib audio/gstreamer1-plugins-twolame audio/gstreamer1-plugins-vorbis audio/gstreamer1-plugins-wavpack audio/gstreamer1-plugins-webrtcdsp audio/gtkguitune audio/gtkpod audio/guitarix-lv2 audio/icecast audio/icecast-kh audio/ices audio/jalv audio/jalv-select audio/kid3 audio/lash audio/libgpod audio/libmusicbrainz5 audio/mate-media audio/muse-sequencer audio/owntone audio/paprefs audio/patchage audio/pavucontrol audio/psindustrializer audio/qtractor audio/rhythmbox audio/triceratops-lv2 audio/vst3sdk audio/zrythm biology/libcombine biology/libnuml biology/libsbml biology/libsedml biology/ncbi-vdb biology/sra-tools cad/horizon-eda cad/ifcopenshell cad/opencascade cad/openscad cad/openscad-devel cad/openvsp cad/oregano cad/pcb-rnd cad/repsnapper cad/solvespace chinese/fcitx comms/gnocky comms/gstreamer1-plugins-spandsp comms/hamlib comms/sigdigger comms/suscan comms/xastir converters/xml2c databases/akonadi databases/evolution-data-server databases/gmdb2 databases/kbibtex databases/libgda5 databases/libgda5-jdbc databases/libgda5-ldap databases/libgda5-mysql databases/libgda5-postgresql databases/libgda5-ui databases/libgdamm5 databases/mariadb1011-server databases/mariadb105-server databases/mariadb106-server databases/pgadmin3 databases/pgbackrest databases/pgmodeler databases/pointcloud databases/postgis30 databases/postgis31 databases/postgis32 databases/postgis33 databases/postgresql11-contrib databases/postgresql12-contrib databases/postgresql13-contrib databases/postgresql14-contrib databases/postgresql15-contrib databases/postgresql16-contrib databases/qof databases/rrdtool databases/sequeler databases/spatialite databases/spatialite-tools databases/spatialite_gui databases/sqliteodbc databases/virtuoso databases/xrootd deskutils/alarm-clock-applet deskutils/bijiben deskutils/bookworm deskutils/cairo-dock deskutils/cairo-dock-plugins deskutils/easystroke deskutils/elementary-calendar deskutils/genius deskutils/gnome-calendar deskutils/gnome-contacts deskutils/gnome-dictionary deskutils/gnome-maps deskutils/gnome-photos deskutils/gnome-todo deskutils/gnome-tweaks deskutils/gnote deskutils/growl-for-linux deskutils/gxneur deskutils/iconbrowser deskutils/notekit deskutils/pinot deskutils/py-autokey deskutils/recoll deskutils/rubrica deskutils/subsurface deskutils/synapse deskutils/sysctlview deskutils/virt-manager deskutils/xfce4-tumbler deskutils/xpad devel/aegis devel/anjuta devel/appstream devel/appstream-compose devel/appstream-qt devel/autogen devel/collada-dom devel/compiz-bcop devel/creduce devel/csoap devel/dconf devel/dia2code devel/dia2code+ devel/electron22 devel/electron23 devel/electron24 devel/electron25 devel/gconf2 devel/gconfmm26 devel/geany-plugin-pretty-printer devel/gitg devel/glib20 devel/gnome-builder devel/goffice devel/gstreamer1-plugins-soup devel/gtranslator devel/gvfs devel/hwloc devel/hwloc2 devel/kf5-kdoctools devel/kf5-kio devel/libabigail devel/libaravis devel/libassetml devel/libdap devel/libdatovka devel/libdbusmenu devel/libgdata devel/libght devel/libglade2 devel/libglademm24 devel/libgnt devel/libgsf devel/libical devel/libiqxmlrpc devel/liblangtag devel/libnotify devel/libosinfo devel/libpeas devel/libplist devel/libqb devel/librcc devel/librest devel/libsmpp34 devel/libsoup devel/libsoup3 devel/libvirt devel/libvirt-glib devel/llvm-devel devel/llvm10 devel/llvm11 devel/llvm12 devel/llvm13 devel/llvm14 devel/m17n-lib devel/msitools devel/pcsc-cyberjack devel/py-libpeas devel/py-lxml devel/regexxer devel/root devel/shiboken2 devel/shiboken6 devel/smooth devel/sope devel/sope2 devel/tclxml devel/ticcutils devel/umbrello devel/universal-ctags devel/wf-config devel/xdg-user-dirs devel/z88dk devel/zapcc dns/bind-tools dns/bind9-devel dns/bind916 dns/bind918 dns/opendnssec2 editors/abiword editors/diamond editors/elementary-code editors/emacs editors/emacs-devel editors/gedit editors/gedit-plugins editors/gnome-latex editors/gnome-text-editor editors/gobby editors/gummi editors/jucipp editors/libreoffice editors/marker editors/morla editors/mousepad editors/openoffice-4 editors/openoffice-devel editors/pluma editors/pluma-plugins editors/quilter editors/setzer editors/vscode editors/xed editors/xmlcopyeditor emulators/catapult emulators/dolphin-emu emulators/fuse emulators/higan emulators/nemu emulators/open-vm-tools emulators/qemu-cheri emulators/qemu-devel emulators/qemu-powernv emulators/snes9x-gtk emulators/tiemu3 emulators/virtualbox-ose emulators/virtualbox-ose-legacy emulators/virtualbox-ose-nox11 emulators/virtualbox-ose-nox11-legacy finance/gnucash finance/gnucash-docs finance/grisbi finance/libofx finance/odoo finance/odoo14 finance/odoo15 finance/quickfix french/verbiste ftp/R-cran-RCurl ftp/gstreamer1-plugins-curl games/0ad games/armagetronad games/el games/exult games/exult-devel games/freedoko games/gtkatlantic games/gtkevemon games/gtkradiant games/kanatest games/libmaitretarot games/libmt_client games/lincity-ng games/lordsawar games/maitretarot games/manaplus games/mt_dolphin_ia games/mt_gtk_client games/naev games/netradiant games/openlierox games/py-pychess games/tuxtype games/xmoto graphics/GraphicsMagick graphics/ImageMagick6 graphics/ImageMagick7 graphics/aeskulap graphics/art graphics/aseprite graphics/atril graphics/atril-lite graphics/autopano-sift-c graphics/blender graphics/cairomm graphics/cegui graphics/cluttermm graphics/cptutils graphics/darktable graphics/dcmtk graphics/delaboratory graphics/dia graphics/digikam graphics/elementary-photos graphics/eog-plugins graphics/eom graphics/evince graphics/flam3 graphics/frogr graphics/fyre graphics/gdal graphics/gdk-pixbuf2 graphics/gdk-pixbuf2-xlib graphics/gimmage graphics/gnash graphics/goocanvasmm2 graphics/gpaint graphics/gstreamer1-plugins-aalib graphics/gstreamer1-plugins-cairo graphics/gstreamer1-plugins-gdkpixbuf graphics/gstreamer1-plugins-gl graphics/gstreamer1-plugins-jpeg graphics/gstreamer1-plugins-kms graphics/gstreamer1-plugins-libcaca graphics/gstreamer1-plugins-libvisual graphics/gstreamer1-plugins-opencv graphics/gstreamer1-plugins-openexr graphics/gstreamer1-plugins-openjpeg graphics/gstreamer1-plugins-png graphics/gstreamer1-plugins-qt graphics/gstreamer1-plugins-rsvg graphics/gstreamer1-plugins-vulkan graphics/gstreamer1-plugins-webp graphics/gstreamer1-plugins-zbar graphics/iccxml graphics/inkscape graphics/libetonyek01 graphics/libgnomecanvasmm26 graphics/libgphoto2 graphics/libkdcraw graphics/libopenraw graphics/librsvg2 graphics/librsvg2-rust graphics/libsvg graphics/mapnik graphics/minder graphics/nip2 graphics/opencollada graphics/openfx-arena graphics/openslide graphics/oyranos graphics/podofo graphics/poppler graphics/poppler-glib graphics/poppler-qt5 graphics/poppler-qt6 graphics/poppler-utils graphics/qgis graphics/qgis-ltr graphics/rawstudio graphics/rawtherapee graphics/sane-airscan graphics/sane-backends graphics/shotwell graphics/swfmill graphics/synfig graphics/synfigstudio graphics/tinyows graphics/vips graphics/waffle graphics/wayland graphics/xournal graphics/xournalpp graphics/yafaray irc/hexchat java/openjfx14 lang/cling lang/crystal lang/ferite lang/frawk lang/gnu-cobol lang/gnustep-base lang/php80 lang/php81 lang/php82 lang/php83 lang/vala mail/astroid mail/balsa mail/cone mail/evolution mail/evolution-ews mail/geary mail/gnubiff math/R-cran-igraph math/cadabra2 math/coq math/drgeo math/ggobi math/gkmap math/gnome-calculator math/gnumeric math/gretl math/igraph math/libqalculate math/mate-calc math/mdal math/openturns math/pdal math/polymake math/pspp math/py-igraph math/qalculate-gtk math/sc-im math/scilab math/tablix math/timbl misc/copperspice-examples misc/gimp-help-en misc/hotkeys misc/iio-oscilloscope misc/libcomps misc/libiio misc/liblxi misc/librepo misc/libsupertone misc/parley misc/py-pyqir misc/shared-mime-info misc/tellico misc/visp misc/xfce4-weather-plugin misc/xiphos multimedia/audacious-plugins multimedia/avidemux multimedia/avidemux-cli multimedia/avidemux-plugins multimedia/avidemux-qt5 multimedia/dvdauthor multimedia/ffmpeg multimedia/ffmpeg4 multimedia/gmerlin multimedia/gstreamer1-editing-services multimedia/gstreamer1-plugins multimedia/gstreamer1-plugins-aom multimedia/gstreamer1-plugins-assrender multimedia/gstreamer1-plugins-bad multimedia/gstreamer1-plugins-dash multimedia/gstreamer1-plugins-dts multimedia/gstreamer1-plugins-dv multimedia/gstreamer1-plugins-dvdread multimedia/gstreamer1-plugins-good multimedia/gstreamer1-plugins-hls multimedia/gstreamer1-plugins-libde265 multimedia/gstreamer1-plugins-mpeg2dec multimedia/gstreamer1-plugins-mpeg2enc multimedia/gstreamer1-plugins-mplex multimedia/gstreamer1-plugins-msdk multimedia/gstreamer1-plugins-openh264 multimedia/gstreamer1-plugins-resindvd multimedia/gstreamer1-plugins-rtmp multimedia/gstreamer1-plugins-smoothstreaming multimedia/gstreamer1-plugins-theora multimedia/gstreamer1-plugins-ttml multimedia/gstreamer1-plugins-ugly multimedia/gstreamer1-plugins-v4l2 multimedia/gstreamer1-plugins-vpx multimedia/gstreamer1-plugins-x264 multimedia/gstreamer1-plugins-x265 multimedia/gstreamermm multimedia/handbrake multimedia/kodi multimedia/libbluray multimedia/mlt7 multimedia/mythtv multimedia/ogmrip multimedia/phonon-gstreamer multimedia/totem multimedia/totem-pl-parser multimedia/vcdimager multimedia/vlc net/Sockets net/asterisk16 net/asterisk18 net/ceph14 net/fort net/gfbgraph net/glusterfs net/gnome-online-accounts net/gnome-online-miners net/gq net/grilo net/grilo-plugins net/gstreamer1-plugins-srtp net/gupnp net/gupnp-av net/gupnp-dlna net/gupnp-tools net/gupnp14 net/kamailio net/kitinerary net/libcmis net/libgrss net/libgweather net/libgweather4 net/liblinphone net/libmateweather net/librest1 net/liferea net/mediastreamer net/mobile-broadband-provider-info net/ns3 net/opensips31 net/pacemaker1 net/pacemaker2 net/pecl-xmlrpc net/php80-soap net/php81-soap net/php82-soap net/php83-soap net/rubygem-ovirt-engine-sdk net/vinagre net/wireshark net/yaz net-im/finch net-im/folks net-im/fractal net-im/kopete net-im/libaccounts-glib net-im/libpurple net-im/pidgin net-im/pidgin-sipe net-im/pidgin-twitter net-im/signal-desktop net-im/telepathy-farstream net-im/telepathy-gabble net-im/telepathy-glib net-im/telepathy-idle net-im/telepathy-logger net-im/telepathy-logger-qt5 net-im/telepathy-mission-control net-im/telepathy-qt net-im/telepathy-salut net-mgmt/fence-agents net-mgmt/lldpd net-mgmt/ndpmon net-mgmt/torrus net-mgmt/virt-viewer net-mgmt/zabbix5-proxy net-mgmt/zabbix5-server net-mgmt/zabbix6-proxy net-mgmt/zabbix6-server net-mgmt/zabbix64-proxy net-mgmt/zabbix64-server net-p2p/dclib net-p2p/gtk-gnutella net-p2p/linuxdcpp net-p2p/microdc2 net-p2p/minder net-p2p/retroshare net-p2p/tooth news/nzbget print/fontforge print/foomatic-db-engine print/miktex print/pdfchain print/scribus-devel print/simple-fb2-reader print/xreader science/abinit science/afni science/chemical-mime-data science/chrono science/code_saturne science/fleur science/gchemutils science/ghemical science/ghmm science/gromacs science/lammps science/openbabel science/openmodelica science/orthanc science/paraview science/precice science/py-pymol science/qmcpack science/qwalk science/salome-kernel security/beid security/bzrtp security/clamav security/clamav-lts security/gnome-keyring security/gonepass security/gsad security/gstreamer1-plugins-dtls security/gvm-libs security/gvmd security/kc security/lasso security/lastpass-cli security/libpki security/libsecret security/modsecurity3 security/oath-toolkit security/openca-ocspd security/openconnect security/pwman security/py-xmlsec security/stoken security/xmlsec1 sysutils/accountsservice sysutils/brasero sysutils/budgie-control-center sysutils/bulk_extractor sysutils/cfengine sysutils/cfengine-devel sysutils/cfengine320 sysutils/cfengine321 sysutils/cfengine322 sysutils/cinnamon-control-center sysutils/cinnamon-settings-daemon sysutils/cluster-glue sysutils/consolekit2 sysutils/fusefs-s3fs sysutils/gapcmon sysutils/gconf-editor sysutils/gnome-control-center sysutils/gnome-system-monitor sysutils/graveman sysutils/gsmartcontrol sysutils/gstreamer1-plugins-cdio sysutils/istatserver sysutils/jstest-gtk sysutils/khelpcenter sysutils/libdnf sysutils/ltfs sysutils/lttng-tools sysutils/mate-control-center sysutils/mate-system-monitor sysutils/nitrogen sysutils/osinfo-db-tools sysutils/quicksynergy sysutils/tracker sysutils/tracker-miners sysutils/tracker3 sysutils/upower sysutils/wimlib sysutils/xen-tools textproc/R-cran-XML textproc/R-cran-xml2 textproc/apertium textproc/asciidoc textproc/augeas textproc/diffmark textproc/docbook2X textproc/ebook-tools textproc/fpc-libxml2 textproc/gdome2 textproc/gmetadom textproc/gspell textproc/gstreamer1-plugins-zxing textproc/gtk-doc textproc/lasem textproc/libabw textproc/libcroco textproc/libe-book textproc/libextractor textproc/libfo textproc/libfolia textproc/libgepub textproc/liblingoteach textproc/libodfgen01 textproc/libtranslate textproc/libvisio01 textproc/libwpd010 textproc/libxml++ textproc/libxml++26 textproc/libxml++30 textproc/libxslt textproc/lttoolbox textproc/obsidian textproc/p5-XML-CanonicalizeXML textproc/p5-XML-LibXML textproc/p5-XML-LibXSLT textproc/php80-dom textproc/php80-simplexml textproc/php80-xml textproc/php80-xmlreader textproc/php80-xmlwriter textproc/php80-xsl textproc/php81-dom textproc/php81-simplexml textproc/php81-xml textproc/php81-xmlreader textproc/php81-xmlwriter textproc/php81-xsl textproc/php82-dom textproc/php82-simplexml textproc/php82-xml textproc/php82-xmlreader textproc/php82-xmlwriter textproc/php82-xsl textproc/php83-dom textproc/php83-simplexml textproc/php83-xml textproc/php83-xmlreader textproc/php83-xmlwriter textproc/php83-xsl textproc/py-libxml2 textproc/raptor textproc/raptor2 textproc/rubygem-libxml-ruby textproc/rubygem-nokogiri textproc/rubygem-nokogiri111 textproc/rubygem-nokogumbo textproc/rubygem-ruby-augeas textproc/rubygem-ruby-xslt textproc/ssddiff textproc/ucto textproc/wv textproc/wv2 textproc/xmlroff textproc/xmlstarlet textproc/xmlwrapp textproc/yelp-tools textproc/yelp-xsl textproc/zorba www/apache24 www/aria2 www/badwolf www/bluefish www/castget www/chromium www/cssed www/davix www/epiphany www/flickcurl www/gnome-user-share www/gstreamer1-plugins-neon www/gstreamer1-plugins-srt www/hiawatha www/hurl www/iridium www/kannel www/kannel-sqlbox www/midori www/mod_php80 www/mod_php81 www/mod_php82 www/mod_php83 www/mod_security www/newsboat www/nghttp2 www/nginx-full www/pecl-solr www/py-html5-parser www/qt5-webengine www/qt5-webkit www/qt6-webengine www/rssroll www/rsstool www/sitecopy www/tidy-html5 www/trafficserver www/ungoogled-chromium www/webkit2-gtk3 www/webkit2-gtk4 x11/apwal x11/budgie-screensaver x11/cinnamon x11/cinnamon-screensaver x11/gnome-console x11/gnome-pie x11/gnome-shell x11/gnome-terminal x11/gstreamer1-plugins-x x11/gstreamer1-plugins-ximagesrc x11/jgmenu x11/keyboardcast x11/libxkbcommon x11/libxklavier x11/lxpanel x11/mate-applets x11/mate-session-manager x11/nwg-launchers x11/pipeglade x11/plank x11/roxterm x11/swaysettings x11/waybar x11/wbar x11/wcm x11/wf-shell x11/workrave x11/xapp x11/xfce4-screenshooter-plugin x11/xfce4-terminal x11/xkeyboard-config x11/xscreensaver x11/xsnow x11/yelp x11-clocks/cairo-clock x11-fm/caja x11-fm/fsv2 x11-fm/librfm x11-fm/nautilus-python x11-fm/nemo x11-fm/polo x11-fm/rodent x11-fm/rox-filer x11-fm/sushi x11-fonts/afdko x11-fonts/font-manager x11-themes/adapta-backgrounds x11-themes/adapta-gtk-theme x11-themes/plata-theme x11-toolkits/copperspice x11-toolkits/gdl x11-toolkits/gstreamer1-plugins-gtk x11-toolkits/gstreamer1-plugins-pango x11-toolkits/gtk-sharp20 x11-toolkits/gtkmm24 x11-toolkits/gtkmm30 x11-toolkits/gtksourceview2 x11-toolkits/gtksourceview3 x11-toolkits/gtksourceview4 x11-toolkits/gtksourceview5 x11-toolkits/gtksourceviewmm3 x11-toolkits/guile-gnome-platform x11-toolkits/ocaml-lablgtk2 x11-toolkits/ocaml-lablgtk3 x11-toolkits/p5-Glade2 x11-toolkits/p5-Gtk2-GladeXML x11-toolkits/pangomm x11-toolkits/rubygem-gtksourceview3 x11-toolkits/rubygem-gtksourceview4 x11-toolkits/tepl6 x11-wm/compiz x11-wm/compiz-plugins-extra x11-wm/compiz-plugins-main x11-wm/compiz-plugins-unsupported x11-wm/labwc x11-wm/libcompizconfig x11-wm/lxappearance-obconf x11-wm/lxsession x11-wm/obconf x11-wm/obconf-qt x11-wm/openbox
Fallouts related to libxml2 that are not listed as BROKEN/IGNORE etc: lang/gnustep-base (Working on this) net/gupnp14 - Legacy version of net/gupnp, required by deskutils/caja-extensions which is a run-time requirement for x11/mate net/gupnp-av - Also shares the legacy codebase of gupnp textproc/raptor - Legacy version, expires 2023-09-30 The CMakeLists.txt patching is to mimic Autotools .pc file, I intend to upstream these changes
Ship it after all dependencies!
Still not understanding why the move to CMake at a fundamental level.
Hi, On behalf of desktop@ I'd like to request an exp-run. Thanks in advance! Best regards, Daniel
Friendly ping
(In reply to Daniel Engberg from comment #5) Not until an explanation is provided on the switch to CMake. The version update is fine, but bundling it with another attempt to switching to CMake is less. What was learnt from last time, what are the technical attributes favouring one provided build system over another, particularly when comparing peer systems, maintenance considerations for us, etc etc.
It has been explained to you earlier, I don't see any reason to discuss your disagreement further as it's already been approved by several other members. fwiw, there's also work done upstream on improving support by several individuals and so we're going to see even better support in 2.12 and very likely no need to use any local patches at all.
(In reply to Daniel Engberg from comment #7) Nope. There has been no real explanation whatsoever that I can see, so you will need to point to where that was, also for the benefit of the rest of the class. Said several other members have not adequately evaluated this change enough to quell anything, especially after the mess last time. This is an area where exp-runs have shown to not be enough.
(In reply to Charlie Li from comment #8) Charlie, if you want to hold up the -exp run and things moving forward, prove the fall-out. And if by reference to prior run-time issues not covered by an -exp run.
(In reply to Matthias Andree from comment #9) This bug could have been moved forward already by not also changing the build to CMake. As a desktop@ member I currently do not approve of the change to CMake, but the update otherwise is (pending optional exp-run). The onus is on those who are pushing for CMake to explain, and preferably in a separate change process.
Charlie, you are sending inconsistent and contradictory messages. That is not helpful at all, and it seems the burdenful test builds were already executed by diizzy@ who is now asking for broader exposure through the -exp run. What is the technical reason and what are the particular ports and past issues that auto* would serve and CMake does not? You have been asked to cite those but fail to. Meaning the refusal looks arbitrary to me.
(In reply to Matthias Andree from comment #11) Test builds, no matter how burdenful, are not relevant to the more fundamental question of why switch to CMake at all. Since I happen to feel generous/charitable today, please refer to bug 262877 and bug 263094, which should have been addressed by https://gitlab.gnome.org/GNOME/libxml2/-/issues/360 and https://gitlab.gnome.org/GNOME/libxml2/-/issues/365 , in theory. There was another about circular dependencies, but that dealt more with CMake itself, which resolved itself when curl became a bundled rather than linked library. However, upstream continues to admit that CMake support is incomplete in https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/221#note_1836398 , which alone does not inspire any confidence to have this in our main ports tree. For the record, I don't really give a shit on which build system we ultimately use, but I do care about upstream support on the choices we do make, our (desktop@) maintenance burden, keeping consumers happy and reducing support threads in our project amongst other things. Feel free to continue improving CMake support upstream and outside the ports tree, but until upstream declare CMake production-ready for platforms like us (ie not Windows), it simply doesn't belong here.
They were quickly fixed once reported, this patch has also been up for almost a month now so if you have concerns feel free to test (which is always welcomed) and report. We have also as I've mentioned previously upstreamed patches and reported issues which hasn't occurred for years and there are also more people working on improving libxml2's build frameworks both Autotools and CMake (they're also much closer now in upstream repo) even if CMake recieves more attention right now as of recent.
(In reply to Daniel Engberg from comment #13) Nothing is relevant here until upstream declares CMake production-ready. They can do so by including everything, including a specific announcement that CMake is production-ready for non-Windows systems, needed to match autotools in a *release*. No hunting for commits after the fact or other patches to make and pull in.
Some new failure logs: https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-09-12_15h45m40s/logs/errors/igt-gpu-tools-1.26.1266.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-09-12_15h45m40s/logs/errors/gupnp-av-0.14.1_1.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-09-12_15h45m40s/logs/errors/gupnp14-1.4.4_1.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-09-12_15h45m40s/logs/errors/raptor-1.4.21_8.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-09-12_15h45m40s/logs/errors/cinnamon-5.4.9_3.log
Comment on attachment 244197 [details] Patch for libxml2 Both x11/cinnamon and graphics/igt-gpu-tools failures are related to gtk-doc; building with autotools does not result in these errors. The others are actual API breaks, but textproc/raptor and net/gupnp14 are scheduled for removal.
Created attachment 245097 [details] v2 Uses autotools to build. Now that GNOME gitlab is back up...
I'll have a look at those, thanks
Comment on attachment 244197 [details] Patch for libxml2 We're not using CMake for this release, particularly when upstream did not declare it ready.
(In reply to Charlie Li from comment #16) This claim isn't true on 13.2-RELEASE aarch64 or amd64 (I've even asked another comitter to test your patch with the same results) using Poudriere so I have to ask how did you test this?
(In reply to Daniel Engberg from comment #20) My own poudriere tests on -CURRENT and 13.2-RELEASE, building with autotools, do not exhibit any such errors.
(In reply to Charlie Li from comment #21) Never mind, I build x11/cinnamon with DOCS disabled by default so of course the error condition never shows up. I don't exactly intend on fixing at least the version in tree x11/cinnamon's DOCS build, especially while a wholesale update is being prepped. But on further reading, it may be as simple as reconciling assets marked to ignore in meson to "dangling" links in the respective gtk-doc sources.
igt-gpu-tools also fails so the claim that CMake is the cause isn't valid either.
Right, new libxml2 is validating links more closely but both x11/cinnamon and graphics/igt-gpu-tools' meson have some gtk-doc bits ignored causing "dangling" references. > so the claim that CMake is the cause isn't valid either. Please don't put words in my mouth. While CMake ended up irrelevant in this case, other faults exist upstream such that they have not declared it production-ready in this environment.
Charlie, when is your obstruction going to end? What is pending for the libxml2 2.11.x upgrade and when are you going to resolve or release it?
Created attachment 246432 [details] Patch for libxml2
New failure logs: https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-25_19h54m11s/logs/errors/openvsp-3.36.0.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-25_19h54m11s/logs/errors/igt-gpu-tools-1.26.1266.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-25_19h54m11s/logs/errors/gupnp-av-0.14.1_1.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-25_19h54m11s/logs/errors/gupnp14-1.4.4_1.log https://pkg-status.freebsd.org/package22/data/132amd64-default-foo/2023-11-25_19h54m11s/logs/errors/cinnamon-5.4.9_4.log
Patches have been submitted for all known build failures. net/gupnp14 was removed in 5a3222023bcda3d4b09913c86bd2a11f8f810a97 As branching of 2024Q1 is near it's probably a better to consider committing this after branching. Meanwhile, please test if possible Best regards, Daniel
If you did a mini-exp-run yourself and everything's looking good, please get this in.
This is already outdated, 2.12.3 is out, and still does not declare CMake recommended for Unix-like platforms. Additionally, this upstream issue concerning CMake is still not resolved: https://gitlab.gnome.org/GNOME/libxml2/-/issues/551
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f554d929ca09ac0666f7cfd1d6d2cded9373c986 commit f554d929ca09ac0666f7cfd1d6d2cded9373c986 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-01-12 16:48:15 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-01-12 17:05:02 +0000 net/gupnp-tools: Fix build with libxml2 2.11 Define -Wno-error=deprecated-declarations to fix build PR: 273210 Reported by: antoine (via exp-run) Approved by: portmgr (blanket, build fix) net/gupnp-tools/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=25e6f68a6661303c0c4f23a304d3e0f713e89e11 commit 25e6f68a6661303c0c4f23a304d3e0f713e89e11 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2024-01-10 19:19:14 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2024-01-12 17:05:01 +0000 textproc/libxml2: Update to 2.11.6 Changelog: https://gitlab.gnome.org/GNOME/libxml2/-/blob/v2.11.6/NEWS PR: 273210 Reviewed by: fluffy Approved by: desktop (arrowd) Exp-run by: antoine textproc/libxml2/Makefile | 54 ++++++++--------------- textproc/libxml2/distinfo | 6 +-- textproc/libxml2/files/patch-CMakeLists.txt (new) | 33 ++++++++++++++ textproc/libxml2/files/patch-Makefile.in (gone) | 38 ---------------- textproc/libxml2/files/patch-config.h.in (gone) | 12 ----- textproc/libxml2/files/patch-configure (gone) | 11 ----- textproc/libxml2/files/patch-python_libxml.c | 24 +++++----- textproc/libxml2/pkg-plist | 13 +++--- textproc/py-libxml2/Makefile | 22 +++++---- 9 files changed, 87 insertions(+), 126 deletions(-)