Bug 273299 - graphics/povray37: Clean up Makefile
Summary: graphics/povray37: Clean up Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-22 20:15 UTC by Philipp Ost
Modified: 2023-08-25 06:50 UTC (History)
2 users (show)

See Also:


Attachments
graphics/povray37/Makefile: Clean up Makefile (2.99 KB, patch)
2023-08-22 20:15 UTC, Philipp Ost
bsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2023-08-22 20:15:56 UTC
Created attachment 244290 [details]
graphics/povray37/Makefile: Clean up Makefile

Clean up the Makefile to keep in sync with graphics/povray36 and graphics/povray38:

- set COMPILED_BY variable as proposed by diizzy@
- drop the STATIC option
- make use of ports framework for options PNG, JPEG, TIFF, OPENEXR
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-23 06:36:26 UTC
Thanks for the patch Philipp,

I bumped PORTREVISION too due to the change in options.
Also, it seems that the COMPILED_BY changed meaning from "who built this" to "what platform this software was built in"?

Cheers.
Comment 2 Philipp Ost 2023-08-23 19:04:50 UTC
(In reply to Fernando Apesteguía from comment #1)

Yes. Whoever took care of the POV-Ray ports before me settled on "who built this". I think it's just as fine to change this to "what platform was this built on" as This should still fulfill POV-Ray's requirement that binaries from other sources than the official project be indicated as such. See https://github.com/POV-Ray/povray/blob/76a804d18a30a1dbb0afbc0070b62526715571eb/unix/install.txt#L43 for the official wording.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-25 06:50:06 UTC
Committed,

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-08-25 06:50:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=cbf6cea662f53deb0477cfd5f52b3dffb4cd2de5

commit cbf6cea662f53deb0477cfd5f52b3dffb4cd2de5
Author:     Philipp Ost <bsd@philippost.de>
AuthorDate: 2023-08-23 06:36:42 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-08-25 06:49:45 +0000

    graphics/povray37: Clean up Makefile

     - set COMPILED_BY variable as proposed by diizzy@
     - drop the STATIC option
     - make use of ports framework for options PNG, JPEG, TIFF, OPENEXR

    PR:             273299
    Reported by:    bsd@philippost.de (maintainer)

 graphics/povray37/Makefile | 72 ++++++++++++----------------------------------
 1 file changed, 18 insertions(+), 54 deletions(-)