Bug 273420 - deskutils/coolreader: Update to 3.2.59
Summary: deskutils/coolreader: Update to 3.2.59
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-29 13:00 UTC by Kenneth Raplee
Modified: 2023-09-18 11:04 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mistresssilvara)


Attachments
patch to update to 3.2.59 (8.27 KB, patch)
2023-08-29 13:00 UTC, Kenneth Raplee
no flags Details | Diff
patch to update to 3.2.59 rev2: Reverts the pkg-plist change for share/cr3/hyph/obsolete from @dir back to @comment @dir. (7.96 KB, patch)
2023-08-31 10:24 UTC, Kenneth Raplee
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Raplee 2023-08-29 13:00:18 UTC
Created attachment 244440 [details]
patch to update to 3.2.59

Port patch includes several file patches that rename `lseek64` to `lseek`, since the former is Linux-specific and FreeBSD also handles it as the original.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-30 08:31:27 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

What's the content in share/cr3/obsolete that now we are including in the package?

-@comment @dir share/cr3/hyph/obsolete
+@dir share/cr3/hyph/obsolete

Thanks!
Comment 2 Kenneth Raplee 2023-08-30 18:31:01 UTC
(In reply to Fernando Apesteguía from comment #1)

Unfortunately, I couldn't find the changelog or release notes contents from the author's github repository. There is no changelog file in the repo or any notes from this version's release tag: https://github.com/buggins/coolreader/releases/tag/cr3.2.59

With regards to the `@dir share/cr3/hyph/obsolete`, I was just following what poudriere-testport(8) was advising me to do. After installing this package, it only installs it as an empty directory.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-31 09:58:00 UTC
(In reply to Kenneth Raplee from comment #2)
What suggestion was that?

I used @comment as before, built the port with testport and couldn't see anything. I might have missed it.
Comment 4 Kenneth Raplee 2023-08-31 10:18:34 UTC
(In reply to Fernando Apesteguía from comment #3)

At the time it said something about `@comment @dir share/cr3/hyph/obsolete` being orphaned. However, after getting your input, I just tried adding back the @comment and testport'd again and it's not a problem anymore. So I don't know what happened from before, but it's not a problem anymore. Probably a PEBKAC on my side.
Comment 5 Kenneth Raplee 2023-08-31 10:24:53 UTC
Created attachment 244517 [details]
patch to update to 3.2.59 rev2: Reverts the pkg-plist change for share/cr3/hyph/obsolete from @dir back to @comment @dir.
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-18 11:04:01 UTC
Committed,

Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-18 11:04:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4b64cf228ff8d9a57e902d06df776272474f750b

commit 4b64cf228ff8d9a57e902d06df776272474f750b
Author:     Kenneth Raplee <kenrap@kennethraplee.com>
AuthorDate: 2023-08-30 08:32:31 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-09-18 11:03:37 +0000

    deskutils/coolreader: Update to 3.2.59

    PR:             273420
    Reported by:    kenrap@kennethraplee.com
    Approved by:    mistresssilvara@hotmail.com (maintainer, timeout > 2 weeks)

 deskutils/coolreader/Makefile                      |  6 +-
 deskutils/coolreader/distinfo                      |  6 +-
 ...ngine_src_lvstream_lvfilemappedstream.cpp (new) | 11 +++
 ...ch-crengine_src_lvstream_lvfilestream.cpp (new) | 11 +++
 .../patch-thirdparty_unman_chmlib_configure (new)  | 89 ++++++++++++++++++++++
 ...atch-thirdparty_unman_chmlib_configure.in (new) | 11 +++
 ...tch-thirdparty_unman_chmlib_src_chm_lib.c (new) | 16 ++++
 deskutils/coolreader/pkg-plist                     |  1 +
 8 files changed, 145 insertions(+), 6 deletions(-)