Bug 273435 - sysutils/pefs-kmod: Update to build under FreeBSD 14 & 15
Summary: sysutils/pefs-kmod: Update to build under FreeBSD 14 & 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2023-08-30 04:53 UTC by Daniel O'Connor
Modified: 2023-09-06 22:46 UTC (History)
1 user (show)

See Also:


Attachments
Update port to build on 14 & 15 (1.43 KB, patch)
2023-08-30 04:53 UTC, Daniel O'Connor
darius: maintainer-approval+
Details | Diff
Update to version which works on FreeBSD <14 (1.43 KB, patch)
2023-09-05 22:29 UTC, Daniel O'Connor
darius: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2023-08-30 04:53:42 UTC
Created attachment 244455 [details]
Update port to build on 14 & 15

Removed check & comment regarding INVARIANTS as it does not appear to be true for 15 and 14 is no longer -current so it doesn't impact there.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-30 08:06:54 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

PORTEPOCH should never be removed. Was that change intentional?

Thanks!
Comment 2 Daniel O'Connor 2023-08-30 12:08:01 UTC
Hi Fernando,
I did intentionally remove PORTEPOCH but now realise I shouldn't have :)

There are no release notes or changelog, it is only some very minor changes to build on FreeBSD 15.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-30 13:22:50 UTC
(In reply to Daniel O'Connor from comment #2)
Thanks for the explanation Daniel.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-08-31 08:52:53 UTC
This builds in 14, but fails for me in 12 and 13:

/pefs-f6db204/sys/modules/pefs/../../fs/pefs/pefs_vnops.c -o pefs_vnops.o
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-f6db204/sys/modules/pefs/../../fs/pefs/pefs_vnops.c:1083:2: error: unterminated function-like macro invocation
        KASSERT(fcnp->cn_flags & (
        ^
/usr/src/sys/sys/kassert.h:121:9: note: macro 'KASSERT' defined here
#define KASSERT(exp,msg) do { \
        ^
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-f6db204/sys/modules/pefs/../../fs/pefs/pefs_vnops.c:3236:7: error: expected '}'
#endif
      ^
/wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-f6db204/sys/modules/pefs/../../fs/pefs/pefs_vnops.c:1064:1: note: to match this '{'
{
^
2 errors generated.
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-f6db204/sys/modules/pefs
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/sysutils/pefs-kmod/work/pefs-f6db204
*** Error code 1

Could you have a look?
Comment 5 Daniel O'Connor 2023-09-05 22:29:06 UTC
Created attachment 244668 [details]
Update to version which works on FreeBSD <14
Comment 6 Daniel O'Connor 2023-09-05 22:29:57 UTC
(In reply to Fernando Apesteguía from comment #4)
Hi Fernando,
Thanks - I obviously didn't test it well enough.. I have updated the original repo and made a new port diff to pull in the fixed version.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-09-06 13:33:22 UTC
Committed,

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-09-06 13:33:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e0b6521ef71a63a20890cc575738e53876fb1b3a

commit e0b6521ef71a63a20890cc575738e53876fb1b3a
Author:     Daniel O'Connor <darius@dons.net.au>
AuthorDate: 2023-09-06 07:03:56 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-09-06 13:32:47 +0000

    sysutils/pefs-kmod: Fix build in 14 and 15

    PR:             273435
    Reported by:    darius@dons.net.au (maintainer)

 sysutils/pefs-kmod/Makefile | 6 ++----
 sysutils/pefs-kmod/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 7 deletions(-)
Comment 9 Daniel O'Connor 2023-09-06 22:46:00 UTC
Thanks Fernando